Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move publishing of REST sample Image from AZP to GHA #1091

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Move publishing of REST sample Image from AZP to GHA #1091

merged 1 commit into from
Sep 28, 2023

Conversation

satota2
Copy link
Contributor

@satota2 satota2 commented Sep 28, 2023

This patch moves publishing of REST sample image from AZP to GHA.
This was the last job running on AZP.

Also, this patch will fix an error encounterd during the image build.
Publishing of REST sample image is now only executed when pushing to main.

@satota2 satota2 force-pushed the move-publishing-rest-image-from-azure-to-gha branch 2 times, most recently from 382479b to f11dd7d Compare September 28, 2023 06:30
@satota2
Move publishing of REST sample Image from AZP to GHA
81a4f71 
This patch moves publishing of REST sample image from AZP to GHA.
This was the last job running on AZP.
Also, this patch fixes an error encounterd during the image build.
Publishing of REST sample image is now only executed when pushing to main.

Signed-off-by: Tatsuya Sato <[email protected]>
@satota2 satota2 force-pushed the move-publishing-rest-image-from-azure-to-gha branch from f11dd7d to 81a4f71 Compare September 28, 2023 06:57
@satota2
Copy link
Contributor Author

satota2 commented Sep 28, 2023 •
edited
Loading

Hi @denyeart
I have attempted to create a patch for migrating the remaining CI jobs of fabric-samples to GHA, as mentioned in the following message:
https://lists.hyperledger.org/g/fabric/message/11994

I would appreciate it if you could review it.
Additionally, I have tried to change the method for "Publishing of REST sample image" to use GITHUB_TOKEN. However, I haven't been able to test it locally or in my own environment, so please verify it.

@satota2 satota2 marked this pull request as ready for review September 28, 2023 07:09
@satota2 satota2 requested a review from a team as a code owner September 28, 2023 07:09
denyeart
denyeart approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@denyeart denyeart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you... I'll merge and we'll see if it works from GitHub Actions...

@denyeart denyeart merged commit bda72ca into hyperledger:main Sep 28, 2023
38 of 41 checks passed
@satota2
Copy link
Contributor Author

satota2 commented Sep 28, 2023

@denyeart Thank you for your merging. It seems publishing of REST sample image works well.
https://github.com/hyperledger/fabric-samples/pkgs/container/fabric-rest-sample

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denyeart denyeart denyeart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@satota2 @denyeart