Upgrade TransactionHandler: Improve readability and error handling #152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified the
String()
method forTransactionHandlerType
:String()
method.fallthrough
for better readability.ErrInvalidTransactionHandlerType
for better error handling.Improved the Call method:
someResp
to response for better clarity.Refactored the
NewTransactionHandler
function:fmt.Errorf
with %w to wrap the error and provide more context.Improved error messages:
Used
errors.New
for static error messages.Used
fmt.Errorf
for dynamic error messages.Updated the struct initialization in NewTransactionHandler to use field names for better clarity.
Signed-off-by: Bhaskar Allam [email protected]