Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Spotless for code formatting #358

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

bestbeforetoday
Copy link
Member

@bestbeforetoday bestbeforetoday commented Oct 22, 2024

Spotless is widely used opinionated Java code formatter. It will also fix incorrect formatting using ./gradlew spotlessApply, avoiding the need for contributors to manually correct any formatting violations flagged by Checkstyle. Formatting rules defined by Checkstyle that would otherwise cause conflicts with the formatting applied by Spotless are removed.

The only non-formatting changes are to CONTRIBUTING.md, build.gradle and ci/checkstyle/checkstyle.xml.

This change also updates the Gradle version to 8.10.2.

Spotless is widely used opinionated Java code formatter. It will also
fix incorrect formatting using `./gradlew spotlessApply`, avoiding the
need for contributors to manually correct any formatting violations
flagged by Checkstyle. Formatting rules defined by Checkstyle that would
otherwise cause conflicts with the formatting applied by Spotless are
removed.

This change also updates the Gradle version to 8.10.2.

Signed-off-by: Mark S. Lewis <[email protected]>
Copy link

sonarcloud bot commented Oct 23, 2024

@bestbeforetoday bestbeforetoday marked this pull request as ready for review October 23, 2024 17:17
@bestbeforetoday bestbeforetoday requested a review from a team as a code owner October 23, 2024 17:17
@bestbeforetoday bestbeforetoday enabled auto-merge (squash) October 23, 2024 17:19
Copy link
Contributor

@denyeart denyeart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bestbeforetoday bestbeforetoday merged commit 4895f92 into hyperledger:main Oct 25, 2024
9 checks passed
@bestbeforetoday bestbeforetoday deleted the spotless branch October 25, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants