Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate dependence of indy-ledger-response-parser on indy-api-types #934

Merged
merged 4 commits into from
Aug 14, 2023

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented Aug 11, 2023

Eliminates dependence of indy-ledger-response-parser on indy-api-types, which now leak out of libvdrtools only through indy-wallet.

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2023

Codecov Report

Merging #934 (ae0a433) into main (3491f23) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 32.43%.

❗ Current head ae0a433 differs from pull request most recent head 49ef32c. Consider uploading reports for the commit 49ef32c to get more accurate results

@@           Coverage Diff           @@
##             main     #934   +/-   ##
=======================================
  Coverage   44.15%   44.16%           
=======================================
  Files         416      418    +2     
  Lines       29231    29241   +10     
  Branches     6239     6240    +1     
=======================================
+ Hits        12908    12913    +5     
- Misses      12517    12519    +2     
- Partials     3806     3809    +3     
Flag Coverage Δ
unittests-aries-vcx 44.16% <32.43%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
indy_ledger_response_parser/src/domain/rev_reg.rs 17.14% <ø> (ø)
indy_ledger_response_parser/src/error.rs 14.28% <14.28%> (ø)
indy_ledger_response_parser/src/domain/response.rs 27.58% <33.33%> (+2.58%) ⬆️
indy_ledger_response_parser/src/lib.rs 43.75% <33.33%> (+1.83%) ⬆️
..._core/src/errors/mapping_ledger_response_parser.rs 44.44% <44.44%> (ø)

... and 3 files with indirect coverage changes

@mirgee mirgee force-pushed the refactor/remove-indy-api-types-from-aries-vcx-core branch from ae0a433 to 49ef32c Compare August 14, 2023 06:49
@Patrik-Stas Patrik-Stas merged commit 0d593ce into main Aug 14, 2023
39 checks passed
@Patrik-Stas Patrik-Stas deleted the refactor/remove-indy-api-types-from-aries-vcx-core branch August 14, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants