Updated indy-credx #931
Merged
Updated indy-credx #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patrik-Stas
reviewed
Aug 10, 2023
bobozaur
force-pushed
the
feature/credx_update
branch
from
ff9f51d
to
b73683e
Compare
gmulhearn
previously approved these changes
Aug 10, 2023
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
bobozaur
force-pushed
the
feature/credx_update
branch
from
16d5e82
to
f474986
Compare
Signed-off-by: Bogdan Mircea <[email protected]>
bobozaur
force-pushed
the
feature/credx_update
branch
from
f474986
to
11606e3
Compare
Codecov Report
@@ Coverage Diff @@
## main #931 +/- ##
==========================================
- Coverage 44.15% 44.14% -0.01%
==========================================
Files 416 416
Lines 29231 29239 +8
Branches 6239 6244 +5
==========================================
+ Hits 12908 12909 +1
- Misses 12517 12524 +7
Partials 3806 3806
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Patrik-Stas
approved these changes
Aug 12, 2023
|
@mirgee please merge if all is ✅ on your side |
mirgee
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #926 .
This introduces yet another feature flag,
legacy_proof, because after a lot of digging the proof request and verification appear to change in credx in a way that's not backwards compatible. However, the feature flag enables a second check of the proof using the legacy method.This is not the default behavior because people might not want to have this enabled at all times.