Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor features, enable build with --no-default-features #918

Merged
merged 5 commits into from
Jul 31, 2023

Conversation

Patrik-Stas
Copy link
Contributor

@Patrik-Stas Patrik-Stas commented Jul 28, 2023

At high level, this re-enables building aries-vcx, aries-vcx-core without any features enabled. Comes along with some refactoring to make sense of things and prepare ground for gradual removal of vdrtools based components.

  • aries-vcx-core: define more granular features - this will come handy in subsequent PR's removing parts of vdrtools vdrtools_anoncreds, vdrtools_wallet, vdrtools_ledger
  • move non-indy specific files out of indy directories (eg ToBaseAgencyClientWallet moved from aries_vcx_core::wallet::indy::agency_client_wallet to aries_vcx_core::wallet::agency_client_wallet
  • aries-vcx-core: include indy-api-types as dependency to access indy_api_types::errors directly to simplify error mapping (aries_vcx_core/src/errors/mapping_vdrtools.rs )
  • remove support for vdrtools based ledger client from did_resolver_sov - it was causing some complications which won't be relevant as soon as this Replace vdrtool ledger client by indy-vdr client #914 get merged

@Patrik-Stas Patrik-Stas force-pushed the refactor/no-default-feature branch 3 times, most recently from 654486e to 2426163 Compare July 28, 2023 11:39
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2023

Codecov Report

Merging #918 (db372ee) into main (29cde27) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #918      +/-   ##
==========================================
- Coverage   43.34%   43.34%   -0.01%     
==========================================
  Files         438      438              
  Lines       34847    34847              
  Branches     7606     7604       -2     
==========================================
- Hits        15104    15103       -1     
  Misses      15262    15262              
- Partials     4481     4482       +1     
Flag Coverage Δ
unittests-aries-vcx 43.34% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
aries_vcx/src/handlers/connection/cloud_agent.rs 70.00% <ø> (ø)
aries_vcx/src/protocols/connection/generic/mod.rs 0.00% <ø> (ø)
...ies_vcx/src/utils/mockdata/profile/mock_profile.rs 0.00% <ø> (ø)
aries_vcx/src/utils/mod.rs 50.00% <ø> (ø)
aries_vcx/src/utils/provision.rs 77.77% <ø> (ø)
aries_vcx/tests/test_agency.rs 77.60% <ø> (ø)
...ries_vcx_core/src/errors/mapping_indy_api_types.rs 32.35% <ø> (ø)
aries_vcx_core/src/ledger/mod.rs 0.00% <ø> (ø)
aries_vcx_core/src/wallet/agency_client_wallet.rs 17.47% <ø> (ø)
aries_vcx_core/src/wallet/base_wallet.rs 0.00% <ø> (ø)
... and 5 more

... and 1 file with indirect coverage changes

aries_vcx_core/Cargo.toml Show resolved Hide resolved
@Patrik-Stas Patrik-Stas merged commit 72b74a2 into main Jul 31, 2023
@Patrik-Stas Patrik-Stas deleted the refactor/no-default-feature branch July 31, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants