Android script fix & Askar impl on Kotlin mobile demo #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alberto-instnt
commented
Jul 20, 2024
alberto-instnt
commented
- Adjusted the directory on the android script.
- Added a AskarWallet to the Kotlin mobile demo
new sh command with the new folder structure Signed-off-by: alberto-instnt <[email protected]>
Updated unffi README.md
Fork sync - readme and suppressed wranings
…le demo Signed-off-by: Alberto Leon <[email protected]>
JamesKEbert
previously approved these changes
Jul 22, 2024
Signed-off-by: Alberto Leon <[email protected]>
|
@JamesKEbert Your right I missed that commit. Please review again. Thanks for the observation. Also please take a look at my implementation of keyMethod per your suggestion. |
lukewli-anonyome
pushed a commit
to lukewli-anonyome/aries-vcx
that referenced
this pull request
Jul 25, 2024
* Updated unffi README.md new sh command with the new folder structure Signed-off-by: alberto-instnt <[email protected]> * adjusted android script and added askar implementation on kotlin mobile demo Signed-off-by: Alberto Leon <[email protected]> * added AskarWalletConfig on mobile demo Signed-off-by: Alberto Leon <[email protected]> --------- Signed-off-by: alberto-instnt <[email protected]> Signed-off-by: Alberto Leon <[email protected]> Signed-off-by: lli <[email protected]>
alberto-instnt
added a commit
to instnt-inc/instnt-aries-vcx
that referenced
this pull request
Sep 10, 2024
* Updated unffi README.md new sh command with the new folder structure Signed-off-by: alberto-instnt <[email protected]> * adjusted android script and added askar implementation on kotlin mobile demo Signed-off-by: Alberto Leon <[email protected]> * added AskarWalletConfig on mobile demo Signed-off-by: Alberto Leon <[email protected]> --------- Signed-off-by: alberto-instnt <[email protected]> Signed-off-by: Alberto Leon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.