-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
supports larger sized input & output utxos #83
Conversation
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
0f93115
to
7602dae
Compare
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
golang witness generation concurrency test
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great over all! have a few minor comments only. but did have one important question on why the verifiers for the 2-sized inputs were updated
@@ -43,35 +43,44 @@ contract Groth16Verifier_AnonEnc { | |||
uint256 constant deltay2 = 8495653923123431417604973247489272438418190587263600148770280649306958101930; | |||
|
|||
|
|||
uint256 constant IC0x = 5696326670703652601376328914723856805804139150397636629981154943267586835846; | |||
uint256 constant IC0y = 17913431813079674015620165360736989993822627917830194405007674349883405519566; | |||
uint256 constant IC0x = 15520848054661511274945320545667385548601069271438999324366330478358568711164; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
has the circuit changed for this pattern? if so what's the change? It's not obvious from the PR since the circom file got moved (so there wasn't a comparison view)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tokens that has encrypted values now returns the encrypted values of all output UTXOs. 273cf81#diff-23144eb2dba1e5a2d0426bafde4a643be7543faad3ad1af139cc84065ece1df4
Before the change, the circuit only return the first UTXO and had a convention that's the receiver's UTXOs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aha! glad I asked about this, I somehow missed the updates to the circuits for the encryption part. see my comments below
Support ephemeral private key for generating ecdh shared key for encryption
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
I've missed the Golang e2e test several times as the test results were cached despite circuit changes. Going to disable result caching for integration test |
Signed-off-by: Chengxuan Xing <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! thanks @Chengxuan for the great work on this!
This PR propose a method for all the fungible tokens to support more than 2 inputs.
-v
verbose mode which prints out output of circom commands. it contains the number of constraints in the generated circuit, which is helpful for picking PTAU filesResolves #8