Fix NWO when there is no FSC topology #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandros Filios <[email protected]>
adecaro
reviewed
Sep 25, 2024
| @@ -47,7 +47,11 @@ func (n *Network) CheckTopologyOrderers() { | |||
| // CheckTopologyFSCNodes checks that the FSC nodes' are well configured. | |||
| // It returns the parameters to be used for cryptogen. | |||
| func (n *Network) CheckTopologyFSCNodes() (users map[string]int, userSpecs map[string][]topology.UserSpec) { | |||
| fscTopology := n.Context.TopologyByName("fsc").(*fsc.Topology) | |||
| t := n.Context.TopologyByName("fsc") | |||
There was a problem hiding this comment.
I'm wondering if we should fail here because no FSC nodes have been configured. Maybe not, if one wants to use NWO to generate fabric related artifacts.
There was a problem hiding this comment.
I think it would be nice if you can define a topology without any FSC nodes - just for whatever testing reason.
I am actually wondering why the fabric (nwo) platform performs this check? Shouldn't every nwo platform be independent and than nwo will perform this check (from outside the platforms)?
mbrandenburger
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.