db and vault should treat a key's version generically #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adecaro
force-pushed
the
f-vault-generic-version
branch
from
a73f08c
to
706b425
Compare
adecaro
force-pushed
the
f-vault-generic-version
branch
from
706b425
to
c2956ca
Compare
mbrandenburger
approved these changes
Sep 26, 2024
alexandrosfilios
requested changes
Oct 3, 2024
|
|
||
| func FromBytes(data []byte) (driver.BlockNum, driver.TxNum, error) { | ||
| if len(data) == 0 { | ||
| return 0, 0, nil |
There was a problem hiding this comment.
Is this not an error?
| Block driver.BlockNum | ||
| TxNum driver.TxNum | ||
| } | ||
| type Version = []byte |
There was a problem hiding this comment.
Is this different from RawVersion?
| @@ -15,6 +15,8 @@ import ( | |||
| "time" | |||
| "unicode/utf8" | |||
|
|
|||
| "github.com/hyperledger-labs/fabric-smart-client/platform/common/core/generic/vault/fver" | |||
|
|
|||
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Alexandros Filios <[email protected]>
alexandrosfilios
force-pushed
the
f-vault-generic-version
branch
from
573ab97
to
4dc84b0
Compare
alexandrosfilios
approved these changes
Oct 5, 2024
There was a problem hiding this comment.
LGTM
Waiting on integration with TokenSDK hyperledger-labs/fabric-token-sdk#770
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #665