Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Track and IsTxFinal #681

Merged
merged 6 commits into from
Nov 11, 2024
Merged

remove Track and IsTxFinal #681

merged 6 commits into from
Nov 11, 2024

Conversation

adecaro
Copy link
Contributor

@adecaro adecaro commented Sep 20, 2024

This PR does remove the following view commands:

  • Track. It was not implemented and never requested.
  • IsTxFinal. Each application should provide this functionality only if needed.

@adecaro adecaro added the cleanup Something needs some cleanup label Sep 20, 2024
@adecaro adecaro self-assigned this Sep 20, 2024
@@ -0,0 +1,41 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could reuse the view that we defined before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@alexandrosfilios alexandrosfilios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo comment

Signed-off-by: Angelo De Caro <[email protected]>
Copy link
Contributor

@alexandrosfilios alexandrosfilios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adecaro adecaro merged commit f012d66 into main Nov 11, 2024
20 checks passed
@adecaro adecaro deleted the f-cleanup branch November 11, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Something needs some cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants