remove the txid from the committer list after the listeners have been called #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adecaro
reviewed
Sep 20, 2024
| return | ||
| case <-ticker.C: | ||
| c.mutex.RLock() | ||
| txIDs := c.txIDs.ToSlice() | ||
| c.mutex.RUnlock() | ||
| if len(txIDs) == 0 { | ||
| c.logger.Debugf("no transactions to check vault status") | ||
| // c.logger.Debugf("no transactions to check vault status") | ||
| break | ||
| } | ||
|
|
||
| newCtx, span := c.tracer.Start(context.Background(), "vault_status_check") | ||
| c.logger.Debugf("check vault status for [%d] transactions", len(txIDs)) |
There was a problem hiding this comment.
do you want to remove this?
| return | ||
| case event := <-c.eventQueue: | ||
| c.listenerManager.InvokeListeners(event) | ||
| c.mutex.Lock() |
There was a problem hiding this comment.
this makes me think about handling panics. if InvokeListeners panics, then we don't dispatch events anymore.
|
@arner , please, can you test this commit with token-sdk? |
… called Signed-off-by: Arne Rutjes <[email protected]>
Signed-off-by: Arne Rutjes <[email protected]>
arner
force-pushed
the
f-remove-tx-listeners
branch
from
830ac5f
to
e161523
Compare
| @@ -80,6 +81,7 @@ func (c *FinalityManager[V]) RemoveListener(txID driver.TxID, toRemove driver.Fi | |||
| defer c.mutex.Unlock() | |||
| c.txIDs.Remove(txID) | |||
| c.listenerManager.RemoveListener(txID, toRemove) | |||
| // c.logger.Debugf("removed listener for [%s]: now listening to %d transactions...", txID, c.txIDs.Length()) | |||
There was a problem hiding this comment.
We can remove them or enable them?
|
Superseded by #683 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the list keeps growing, which causes SQL failures after 1000 transactions and possibly other issues as well.