Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improved chaincode event view #506

Merged
merged 7 commits into from
Nov 2, 2023
Merged

improved chaincode event view #506

merged 7 commits into from
Nov 2, 2023

Conversation

adecaro
Copy link
Contributor

@adecaro adecaro commented Oct 26, 2023 •
edited
Loading

This PR brings the following:

  • Ability to set a context when waiting for chaincode events
  • Better lock strategy for the event bus

@adecaro
improved chaincode event view
14a3d25 
Signed-off-by: Angelo De Caro <[email protected]>
@adecaro
fixup! improved chaincode event view
213f75e 
Signed-off-by: Angelo De Caro <[email protected]>
@adecaro
better lock strategy at the event hub
34fcefc 
Signed-off-by: Angelo De Caro <[email protected]>
@adecaro
better error handling p2p
a6a691f 
Signed-off-by: Angelo De Caro <[email protected]>
@adecaro
fix view
3517ba6 
Signed-off-by: Angelo De Caro <[email protected]>
@adecaro adecaro self-assigned this Oct 30, 2023
@adecaro adecaro added the bug Something isn't working label Oct 30, 2023
@adecaro
fix p2p
94bba7e 
Signed-off-by: Angelo De Caro <[email protected]>
@adecaro
fixup! fix p2p
0d79370 
Signed-off-by: Angelo De Caro <[email protected]>
alexandrosfilios
alexandrosfilios approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@alexandrosfilios alexandrosfilios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adecaro adecaro merged commit 5fa8a42 into main Nov 2, 2023
19 checks passed
@adecaro adecaro deleted the f-chaincode-events branch November 2, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandrosfilios alexandrosfilios alexandrosfilios approved these changes

Assignees

@adecaro adecaro

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adecaro @alexandrosfilios