Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make SecretString public #5269

Merged
merged 2 commits into from
Dec 12, 2024
Merged

fix: Make SecretString public #5269

merged 2 commits into from
Dec 12, 2024

Conversation

aoyako
Copy link
Contributor

@aoyako aoyako commented Dec 11, 2024 •
edited
Loading

Basic auth is defined as

pub struct BasicAuth {
    pub web_login: WebLogin,
    pub password: SecretString,
}

Since the constructor of SecretString is not public, a client can't construct a config without using load(). It is currently required by Python lib.

This PR makes SecretString public.

aoyako and others added 2 commits December 11, 2024 17:25
@aoyako
fix: make secret string public
3366c7c 
Signed-off-by: Lohachov Mykhailo <[email protected]>
@aoyako @s8sato
fix: Update crates/iroha/src/secrecy.rs
1cf6661 
Co-authored-by: Shunkichi Sato <[email protected]>
Signed-off-by: Mykhailo Lohachov <[email protected]>
@aoyako aoyako changed the title Fix: Make SecretString public fix: Make SecretString public Dec 11, 2024
s8sato
s8sato approved these changes Dec 11, 2024
View reviewed changes
crates/iroha/src/lib.rs Show resolved Hide resolved
0x009922
0x009922 approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@0x009922 0x009922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a minimal PR description.

@aoyako aoyako merged commit d512102 into hyperledger-iroha:main Dec 12, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s8sato s8sato s8sato approved these changes

@0x009922 0x009922 0x009922 approved these changes

@mversic mversic Awaiting requested review from mversic mversic is a code owner

@SamHSmith SamHSmith Awaiting requested review from SamHSmith SamHSmith is a code owner

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@DCNick3 DCNick3 Awaiting requested review from DCNick3 DCNick3 is a code owner

@dima74 dima74 Awaiting requested review from dima74 dima74 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aoyako @0x009922 @s8sato