Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add listen timeouts to iroha cli #5241

Merged
merged 20 commits into from
Nov 21, 2024
Merged

feat: Add listen timeouts to iroha cli #5241

merged 20 commits into from
Nov 21, 2024

Conversation

aoyako
Copy link
Contributor

@aoyako aoyako commented Nov 18, 2024

Resolves #2941

Now iroha-cli can take argument --timeout=<seconds> for listen commands. The client will exit when no message is received during this interval.

Review notes (optional)

  • For complex PRs, try to provide some information on how to approach the review more effectively.
  • For example, is there a natural order in which the affected files should be reviewed?

Checklist

  • I've read CONTRIBUTING.md.
  • (optional) I've written unit tests for the code changes.
  • All review comments have been resolved.
  • All CI checks pass.

@aoyako
feat: add timeouts to client cli
cb3a5b2 
Signed-off-by: Lohachov Mykhailo <[email protected]>
@aoyako
chore: remove unused macro
5d49a04 
Signed-off-by: Lohachov Mykhailo <[email protected]>
@aoyako aoyako changed the title Add listen timeouts to iroha cli feat: Add listen timeouts to iroha cli Nov 18, 2024
@s8sato s8sato self-assigned this Nov 18, 2024
s8sato
s8sato reviewed Nov 18, 2024
View reviewed changes
crates/iroha_cli/src/main.rs Outdated Show resolved Hide resolved
crates/iroha_cli/src/main.rs Outdated Show resolved Hide resolved
crates/iroha_cli/src/main.rs Show resolved Hide resolved
@aoyako
fix: test codecover
baa3b17 
Signed-off-by: Lohachov Mykhailo <[email protected]>
@aoyako
fix: remove unused tests
ae89ae8 
Signed-off-by: Lohachov Mykhailo <[email protected]>
@aoyako
chore: newlines
805c0fa 
Signed-off-by: Lohachov Mykhailo <[email protected]>
@aoyako
chore: make args global
7738409 
Signed-off-by: Lohachov Mykhailo <[email protected]>
@github-actions github-actions bot added the config-changes Changes in configuration and start up of the Iroha label Nov 18, 2024
@github-actions GitHub Actions
Copy link

@BAStos525

@aoyako
fix: use humantime
10f92a8 
Signed-off-by: Lohachov Mykhailo <[email protected]>
@aoyako
test: add integration test
4b455c1 
Signed-off-by: Lohachov Mykhailo <[email protected]>
@aoyako
Merge branch 'main' into listen_timeouts
f49d375
@aoyako
chore: fmt
a000b8d 
Signed-off-by: Lohachov Mykhailo <[email protected]>
@aoyako
chore: fmt
b1a6295 
Signed-off-by: Lohachov Mykhailo <[email protected]>
s8sato
s8sato previously approved these changes Nov 20, 2024
View reviewed changes
crates/iroha_cli/src/main.rs Show resolved Hide resolved
pytests/iroha_cli_tests/test/events/__init__.py Outdated Show resolved Hide resolved
@aoyako aoyako enabled auto-merge (squash) November 21, 2024 10:42
@aoyako aoyako merged commit 8836304 into hyperledger-iroha:main Nov 21, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mversic mversic mversic left review comments

@s8sato s8sato s8sato approved these changes

@DCNick3 DCNick3 DCNick3 approved these changes

@SamHSmith SamHSmith Awaiting requested review from SamHSmith SamHSmith is a code owner

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@0x009922 0x009922 Awaiting requested review from 0x009922 0x009922 is a code owner

@dima74 dima74 Awaiting requested review from dima74 dima74 is a code owner

Assignees

@DCNick3 DCNick3

@s8sato s8sato

@aoyako aoyako

Labels
config-changes Changes in configuration and start up of the Iroha
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[suggestion] Events listening timeout in Client CLI
5 participants
@aoyako @DCNick3 @0x009922 @mversic @s8sato