Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cactus-connector-fabric): add get transaction receipt by tx id #3644

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RafaelAPB
Copy link
Contributor

Authored-by: Eduardo Vasques [email protected]
Co-authored-by: Rafael Belchior [email protected]
Signed-off-by: Rafael Belchior [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RafaelAPB Please fix the DCO, otherwise looking good to me.

@RafaelAPB RafaelAPB force-pushed the satp-dev-fixup-connector-fabric branch from 0172390 to 05e80aa Compare November 27, 2024 17:28
@RafaelAPB
Copy link
Contributor Author

RafaelAPB commented Nov 27, 2024

@petermetz fixed the PR according to your suggestions. I'm not sure why is the commit is unverified, because I'm signing the commit with a key whose public part is added to GPG keys' configuration space on Github

Authored-by: Eduardo Vasques <[email protected]>
Signed-off-by: Rafael Belchior <[email protected]>
@RafaelAPB RafaelAPB force-pushed the satp-dev-fixup-connector-fabric branch from 05e80aa to a425b76 Compare November 27, 2024 17:40
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RafaelAPB I'm not sure what was wrong with the DCO but it's passing now so I'm OK.

Specifically to what you wrote: It's important to note that the GPG signing keys don't come into play at all from the DCO perspective.
The DCO is just a plain string comparison of the email in your commit message (the "signed-off by" line on the bottom) and the email that you have set up on your github account. So the email you have associated with your GPG key does not get examined at all.

@petermetz
Copy link
Contributor

Oops, there's also a merge conflict, please let me know if you need help with that

@petermetz
Copy link
Contributor

@hyperledger-cacti/cacti-maintainers bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants