-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cactus-connector-fabric): add get transaction receipt by tx id #3644
base: main
Are you sure you want to change the base?
feat(cactus-connector-fabric): add get transaction receipt by tx id #3644
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RafaelAPB Please fix the DCO, otherwise looking good to me.
.../cactus-plugin-ledger-connector-fabric/src/main/typescript/plugin-ledger-connector-fabric.ts
Outdated
Show resolved
Hide resolved
0172390
to
05e80aa
Compare
@petermetz fixed the PR according to your suggestions. I'm not sure why is the commit is unverified, because I'm signing the commit with a key whose public part is added to GPG keys' configuration space on Github |
Authored-by: Eduardo Vasques <[email protected]> Signed-off-by: Rafael Belchior <[email protected]>
05e80aa
to
a425b76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RafaelAPB I'm not sure what was wrong with the DCO but it's passing now so I'm OK.
Specifically to what you wrote: It's important to note that the GPG signing keys don't come into play at all from the DCO perspective.
The DCO is just a plain string comparison of the email in your commit message (the "signed-off by" line on the bottom) and the email that you have set up on your github account. So the email you have associated with your GPG key does not get examined at all.
Oops, there's also a merge conflict, please let me know if you need help with that |
@hyperledger-cacti/cacti-maintainers bump |
Authored-by: Eduardo Vasques [email protected]
Co-authored-by: Rafael Belchior [email protected]
Signed-off-by: Rafael Belchior [email protected]
Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.