Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: add timer() option #25

Merged
merged 2 commits into from
Nov 15, 2023
Merged

client: add timer() option #25

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0790a6
client: add http2_timer option
howardjohn Mar 9, 2023
7b2c137
Update src/client/legacy.rs
seanmonstar Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/client/legacy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ use std::time::Duration;
use futures_util::future::{self, Either, FutureExt, TryFutureExt};
use http::uri::Scheme;
use hyper::header::{HeaderValue, HOST};
use hyper::rt::Timer;
use hyper::{body::Body, Method, Request, Response, Uri, Version};
use tracing::{debug, trace, warn};

Expand Down Expand Up @@ -1349,6 +1350,22 @@ impl Builder {
self
}

/// Provide a timer to execute background HTTP2 tasks
seanmonstar marked this conversation as resolved.
Show resolved Hide resolved
///
/// See the documentation of [`h2::client::Builder::timer`] for more
/// details.
///
/// [`h2::client::Builder::timer`]: https://docs.rs/h2/client/struct.Builder.html#method.timer
pub fn timer<M>(&mut self, timer: M) -> &mut Self
where
M: Timer + Send + Sync + 'static,
{
#[cfg(feature = "http2")]
self.h2_builder.timer(timer);
seanmonstar marked this conversation as resolved.
Show resolved Hide resolved
// TODO(https://github.com/hyperium/hyper/issues/3167) set for pool as well
self
}

/// Set the maximum write buffer size for each HTTP/2 stream.
///
/// Default is currently 1MB, but may change.
Expand Down