fix: limit number of CONTINUATION frames allowed #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noah-Kennedy
approved these changes
Apr 3, 2024
seanmonstar
force-pushed
the
sec-continuation
branch
2 times, most recently
from
f088f11 to
1972dff
Compare
Calculate the amount of allowed CONTINUATION frames based on other
settings.
max_header_list_size / max_frame_size
That is about how many CONTINUATION frames would be needed to send
headers up to the max allowed size. We then multiply by that by a small
amount, to allow for implementations that don't perfectly pack into the
minimum frames *needed*.
In practice, *much* more than that would be a very inefficient peer, or
a peer trying to waste resources.
See https://seanmonstar.com/blog/hyper-http2-continuation-flood/ for
more info.
seanmonstar
force-pushed
the
sec-continuation
branch
from
1972dff to
979a788
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculate the amount of allowed CONTINUATION frames based on other settings.
That is about how many CONTINUATION frames would be needed to send headers up to the max allowed size. We then multiply by that by a small amount, to allow for implementations that don't perfectly pack into the minimum frames needed.
In practice, much more than that would be a very inefficient peer, or a peer trying to waste resources.
See https://seanmonstar.com/blog/hyper-http2-continuation-flood/ for more info.