Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update indexmap to version 2 #698

Merged
merged 5 commits into from
Oct 9, 2023
Merged

Conversation

djc
Copy link
Contributor

@djc djc commented Jun 26, 2023

No description provided.

@djc
Copy link
Contributor Author

djc commented Jun 26, 2023

Hmm, I guess you might not be eager to bump the MSRV to 1.64 yet.

@jplatte
Copy link

jplatte commented Jul 5, 2023

1.64 would be in line with hyper's MSRV policy of the MSRV always being at least 6 months old (1.64.0 was released on Sept. 22, 2022).

I would appreciate this being merged since it removes duplicate versions of indexmap & hashbrown from some dependency trees.

@djc
Copy link
Contributor Author

djc commented Aug 22, 2023

@seanmonstar any opinions?

@khuey
Copy link

khuey commented Aug 23, 2023

Likewise I'd also benefit from this. h2 is the last crate in my dependency tree using indexmap 1.x and hashbrown 0.12.x

@seanmonstar
Copy link
Member

I recently bumped hyper to 1.63 (mostly because Tokio required it, not because hyper needs anything). While it would be within policy to go one more for 1.64, there's one thing that makes me hesitate: Debian stable is currently using 1.63. 🤔

@cuviper
Copy link

cuviper commented Aug 23, 2023

I don't think hashbrown really needs 1.64 -- only recent versions of its optional allocator-api2 dep need that, but its min-dep 0.2.9 does work with 1.63. And I can speak for indexmap that I only set 1.64 to keep up with hashbrown. These could possibly be relaxed!

@djc
Copy link
Contributor Author

djc commented Aug 24, 2023

AIUI Debian stable will be on 1.63 for 2 years, but I don't think it will be tenable for this crate to stick to that for that kind of period. So what's the value in sticking to what Debian stable is today?

@cuviper
Copy link

cuviper commented Aug 24, 2023

At least for indexmap, it would be nice to let Debian users reach that v2 semver upgrade, even though 2.1 etc. may later raise the MSRV beyond 1.63. In this case, there wouldn't be any real sacrifice to offer that carrot.

@ds-cbo
Copy link

ds-cbo commented Sep 28, 2023

indexmap just released version v2.0.1 which supports MSRV 1.63.0. Could this PR get another CI-run?

@seanmonstar
Copy link
Member

Seems like to time period to restart CI builds has expired, and I can't make them run again without a push.

@jplatte
Copy link

jplatte commented Sep 28, 2023

Close & reopen also triggers CI.

@seanmonstar seanmonstar reopened this Sep 28, 2023
@ds-cbo
Copy link

ds-cbo commented Sep 28, 2023

Ah, too bad, we'll have to wait for rust-lang/hashbrown#457 to be released as hashbrown 0.14.1/0.15 before this will work. They seem to be on a quarterly release schedule with the next release guessed to be around October, so we'll need a bit more patience. Thanks for the retry anyway 😊

@cuviper
Copy link

cuviper commented Sep 29, 2023

Rust 1.63 should be sorted out with indexmap v2.0.2 and hashbrown v0.14.1.

@cuviper
Copy link

cuviper commented Oct 6, 2023

To be clear, those 1.63-compatible hashbrown and indexmap versions are already available.

@ds-cbo
Copy link

ds-cbo commented Oct 9, 2023

@seanmonstar Would you mind closing and re-opening the issue again to re-trigger CI? 😙 Should work this time

@djc
Copy link
Contributor Author

djc commented Oct 9, 2023

Pushed a rebased version including some additional dev-dependency bumps.

@seanmonstar seanmonstar merged commit 1f247de into hyperium:master Oct 9, 2023
6 checks passed
0xE282B0 pushed a commit to 0xE282B0/h2 that referenced this pull request Jan 11, 2024
0xE282B0 pushed a commit to 0xE282B0/h2 that referenced this pull request Jan 11, 2024
0xE282B0 pushed a commit to 0xE282B0/h2 that referenced this pull request Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants