-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update indexmap to version 2 #698
Conversation
Hmm, I guess you might not be eager to bump the MSRV to 1.64 yet. |
1.64 would be in line with I would appreciate this being merged since it removes duplicate versions of indexmap & hashbrown from some dependency trees. |
@seanmonstar any opinions? |
Likewise I'd also benefit from this. h2 is the last crate in my dependency tree using indexmap 1.x and hashbrown 0.12.x |
I recently bumped hyper to 1.63 (mostly because Tokio required it, not because hyper needs anything). While it would be within policy to go one more for 1.64, there's one thing that makes me hesitate: Debian stable is currently using 1.63. 🤔 |
I don't think hashbrown really needs 1.64 -- only recent versions of its optional |
AIUI Debian stable will be on 1.63 for 2 years, but I don't think it will be tenable for this crate to stick to that for that kind of period. So what's the value in sticking to what Debian stable is today? |
At least for |
|
Seems like to time period to restart CI builds has expired, and I can't make them run again without a push. |
Close & reopen also triggers CI. |
Ah, too bad, we'll have to wait for rust-lang/hashbrown#457 to be released as hashbrown 0.14.1/0.15 before this will work. They seem to be on a quarterly release schedule with the next release guessed to be around October, so we'll need a bit more patience. Thanks for the retry anyway 😊 |
Rust 1.63 should be sorted out with |
To be clear, those 1.63-compatible |
@seanmonstar Would you mind closing and re-opening the issue again to re-trigger CI? 😙 Should work this time |
Pushed a rebased version including some additional dev-dependency bumps. |
Signed-off-by: Sven Pfennig <[email protected]>
No description provided.