Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frame_write: Use tokio_util::io::framed_write #623

Closed
wants to merge 2 commits into from
Closed

frame_write: Use tokio_util::io::framed_write #623

wants to merge 2 commits into from

Conversation

jxs
Copy link
Contributor

@jxs jxs commented Jun 16, 2022

No description provided.

@seanmonstar seanmonstar requested a review from hawkw June 16, 2022 19:23
seanmonstar
seanmonstar approved these changes Jun 16, 2022
View reviewed changes
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, assuming that the util function does essentially the same thing. I tagged Eliza since I see a bunch of her comments being deleted, but 🤷

hawkw
hawkw approved these changes Jun 16, 2022
View reviewed changes
Copy link
Collaborator

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me --- as you can see, i definitely followed up on that TODO as soon as tokio-util 0.5.1 was released... 😇

@hawkw
Copy link
Collaborator

hawkw commented Jun 16, 2022

@seanmonstar

[...] assuming that the util function does essentially the same thing [...]

I'm pretty sure it does, because IIRC, I basically copied and pasted the (at the time unpublished) code directly out of tokio-util...

hawkw
hawkw reviewed Jun 16, 2022
View reviewed changes
Copy link
Collaborator

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it occurred to me that we maybe should just get rid of the write function, now that it's a very thin wrapper around poll_write_buf.

src/codec/framed_write.rs Outdated Show resolved Hide resolved
src/codec/framed_write.rs Outdated Show resolved Hide resolved
src/codec/framed_write.rs Outdated Show resolved Hide resolved
@LucioFranco
Copy link
Member

Shall we merge?

@jxs
Copy link
Contributor Author

jxs commented Oct 21, 2023

superseeded by #712

@jxs jxs closed this Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkw hawkw hawkw approved these changes

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jxs @hawkw @LucioFranco @seanmonstar