Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit token scope in example #156

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Limit token scope in example #156

merged 1 commit into from
Dec 13, 2024

Conversation

hynek
Copy link
Owner

@hynek hynek commented Dec 13, 2024

fixes #151

like this, @webknjaz?

I had to simplify the artifact name since I'm not sure how to test this easily. I think I would've had to define an output?

webknjaz
webknjaz approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's good. Technically, you could also remap the action output to the build job output and then access it via the ${{ needs }} context, instead of using that hardcoded value.

@hynek hynek merged commit 5c66f46 into main Dec 13, 2024
14 checks passed
@hynek hynek deleted the fix-doc-security branch December 13, 2024 13:45
@hynek
Copy link
Owner Author

hynek commented Dec 13, 2024

thanks! and PR welcome 🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG][docs] Stop suggesting that calling building in the same job as publishing is okay with OIDC enabled
2 participants
@hynek @webknjaz