Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output for name of uploaded artifact #125

Merged
merged 1 commit into from
May 26, 2024

Conversation

rmartin16
Copy link
Contributor

I'd like to avoid needing to assume the name of the artifact in my downstream workflows.

@rmartin16 rmartin16 force-pushed the artifact-name-output branch from 5870e49 to 77ee54a Compare May 26, 2024 16:26
@rmartin16 rmartin16 marked this pull request as ready for review May 26, 2024 16:28
@hynek
Copy link
Owner

hynek commented May 26, 2024

Hi, sorry your work collided with me fixing #123 could you rebase/resolve conflicts? I'll release ASAP then.

@rmartin16 rmartin16 force-pushed the artifact-name-output branch from 77ee54a to 79e899b Compare May 26, 2024 18:26
@rmartin16
Copy link
Contributor Author

Done. Thank you!

@hynek hynek merged commit 33e6e29 into hynek:main May 26, 2024
13 checks passed
@hynek
Copy link
Owner

hynek commented May 26, 2024

Thanks!

@rmartin16 rmartin16 deleted the artifact-name-output branch May 26, 2024 19:32
@rmartin16
Copy link
Contributor Author

rmartin16 commented May 26, 2024

Just as a heads up, I'm about to propose another change. I need to control check-wheel-contents to ignore some of its errors....just in case you'd be willing to entertain that one as well before anther release.

[edit] Actually, I'll just add the config to [tool.check-wheel-contents] in pyproject.toml.

@hynek
Copy link
Owner

hynek commented May 26, 2024

I'm afraid further changes will have to wait until after my big vacation. But feel free to open issues/PRs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants