fix: flaxy unit tests (#495)

Signed-off-by: hxtree <[email protected]>
hxtree · Nov 5, 2023 · ed59cbc · ed59cbc
1 parent 375d29f
commit ed59cbc
Show file tree

Hide file tree

Showing 23 changed files with 105 additions and 94 deletions.
diff --git a/libraries/faker-factory/package.json b/libraries/faker-factory/package.json
@@ -22,8 +22,8 @@
     "build": "tsc",
     "build:all": "rush build -t .",
     "watch": "tsc -w",
-    "test": "jest",
-    "test:cov": "jest --coverage",
+    "test": "jest --runInBand",
+    "test:cov": "jest --coverage --runInBand",
     "lint": "eslint --format visualstudio \"./{stacks,src}/*.ts\"  --fix",
     "lint:ci": "eslint --format visualstudio \"./{stacks,src}/*.ts\"  --fix-dry-run",
     "depcheck": "npx depcheck"

diff --git a/libraries/messaging-schemas/package.json b/libraries/messaging-schemas/package.json
@@ -13,8 +13,8 @@
     "build": "tsc",
     "build:all": "rush build -t .",
     "watch": "tsc -w",
-    "test": "jest",
-    "test:cov": "jest --coverage",
+    "test": "jest --runInBand",
+    "test:cov": "jest --coverage --runInBand",
     "lint": "eslint --format visualstudio \"./{stacks,src}/*.ts\"  --fix",
     "lint:ci": "eslint --format visualstudio \"./{stacks,src}/*.ts\"  --fix-dry-run",
     "depcheck": "npx depcheck"

diff --git a/libraries/nestjs-modules/package.json b/libraries/nestjs-modules/package.json
@@ -21,8 +21,8 @@
     "build": "tsc",
     "build:all": "rush build -t .",
     "watch": "tsc -w",
-    "test": "jest --logHeapUsage",
-    "test:cov": "jest --coverage",
+    "test": "jest --runInBand",
+    "test:cov": "jest --coverage --runInBand",
     "lint": "eslint --format visualstudio \"./{stacks,src}/*.ts\"  --fix",
     "lint:ci": "eslint --format visualstudio \"./{stacks,src}/*.ts\"  --fix-dry-run",
     "depcheck": "npx depcheck"

diff --git a/libraries/validation-schemas/package.json b/libraries/validation-schemas/package.json
@@ -11,8 +11,8 @@
     "build": "tsc",
     "build:all": "rush build -t .",
     "watch": "tsc -w",
-    "test": "jest",
-    "test:cov": "jest --coverage",
+    "test": "jest --runInBand",
+    "test:cov": "jest --coverage --runInBand",
     "lint": "eslint --format visualstudio \"./src/*.ts\"  --fix",
     "lint:ci": "eslint --format visualstudio \"./src/*.ts\"  --fix-dry-run",
     "depcheck": "npx depcheck"

diff --git a/platform/api-gateway/package.json b/platform/api-gateway/package.json
@@ -10,8 +10,8 @@
     "artifact": "create-artifact @cats-cradle/api-gateway",
     "build": "tsc",
     "watch": "tsc -w",
-    "test": "jest",
-    "test:cov": "jest --coverage",
+    "test": "jest --runInBand",
+    "test:cov": "jest --coverage --runInBand",
     "lint": "eslint --format visualstudio \"./{stacks,src}/*.{ts,tsx}\"  --fix",
     "lint:ci": "eslint --format visualstudio \"./{stacks,src}/*.{ts,tsx}\"  --fix-dry-run",
     "cdk:bootstrap": "cdk bootstrap",

diff --git a/platform/cli-tools/create-artifact/package.json b/platform/cli-tools/create-artifact/package.json
@@ -14,8 +14,8 @@
     "create-artifact": "bin/create-artifact",
     "build": "tsc && tsc-alias",
     "build:all": "rush build -t .",
-    "test": "jest",
-    "test:cov": "jest --coverage",
+    "test": "jest --runInBand",
+    "test:cov": "jest --coverage --runInBand",
     "lint": "eslint --format visualstudio \"./{stacks,src}/*.ts\"  --fix",
     "lint:ci": "eslint --format visualstudio \"./{stacks,src}/*.ts\"  --fix-dry-run"
   },

diff --git a/platform/cli-tools/create-artifact/src/__tests__/test-data/package-output.json b/platform/cli-tools/create-artifact/src/__tests__/test-data/package-output.json
@@ -12,8 +12,8 @@
     "create-artifact": "bin/create-artifact",
     "build": "tsc && tsc-alias",
     "build:all": "rush build -t .",
-    "test": "jest",
-    "test:cov": "jest --coverage",
+    "test": "jest --runInBand",
+    "test:cov": "jest --coverage --runInBand",
     "lint": "eslint --format visualstudio \"./{stacks,src}/*.ts\"  --fix",
     "lint:ci": "eslint --format visualstudio \"./{stacks,src}/*.ts\"  --fix-dry-run"
   },

diff --git a/platform/cli-tools/create-bundle/package.json b/platform/cli-tools/create-bundle/package.json
@@ -18,8 +18,8 @@
     "build": "tsc",
     "build:all": "rush build -t .",
     "watch": "tsc -w",
-    "test": "jest",
-    "test:cov": "jest --coverage",
+    "test": "jest --runInBand",
+    "test:cov": "jest --coverage --runInBand",
     "lint": "eslint --format visualstudio \"./{stacks,src}/*.ts\"  --fix",
     "lint:ci": "eslint --format visualstudio \"./{stacks,src}/*.ts\"  --fix-dry-run",
     "depcheck": "npx depcheck"

diff --git a/platform/cli-tools/rush-coverage/package.json b/platform/cli-tools/rush-coverage/package.json
@@ -16,8 +16,8 @@
     "build": "tsc",
     "build:all": "rush build -t .",
     "watch": "tsc -w",
-    "test": "jest",
-    "test:cov": "jest --coverage",
+    "test": "jest --runInBand",
+    "test:cov": "jest --coverage --runInBand",
     "lint": "eslint --format visualstudio \"./{stacks,src}/*.ts\"  --fix",
     "lint:ci": "eslint --format visualstudio \"./{stacks,src}/*.ts\"  --fix-dry-run",
     "depcheck": "npx depcheck"

diff --git a/platform/constructs/package.json b/platform/constructs/package.json
@@ -7,8 +7,8 @@
     "build": "tsc",
     "build:all": "rush build -t .",
     "watch": "tsc -w",
-    "test": "jest",
-    "test:cov": "jest --coverage",
+    "test": "jest --runInBand",
+    "test:cov": "jest --coverage --runInBand",
     "lint": "eslint --format visualstudio \"./{stacks,src}/*.ts\"  --fix",
     "lint:ci": "eslint --format visualstudio \"./{stacks,src}/*.ts\"  --fix-dry-run",
     "depcheck": "npx depcheck"

diff --git a/platform/lambda-layers/package.json b/platform/lambda-layers/package.json
@@ -5,8 +5,8 @@
   "scripts": {
     "build": "tsc",
     "watch": "tsc -w",
-    "test": "jest",
-    "test:cov": "jest --coverage",
+    "test": "jest --runInBand",
+    "test:cov": "jest --coverage --runInBand",
     "lint": "eslint --format visualstudio \"./{stacks,src}/*.{js,ts}\"  --fix",
     "lint:ci": "eslint --format visualstudio \"./{stacks,src}/*.{js,ts}\"  --fix-dry-run",
     "cdk:deploy": "cdk deploy",

diff --git a/platform/lambda-layers/stacks/__snapshots__/nestjs-lambda-layer.stack.test.ts.snap b/platform/lambda-layers/stacks/__snapshots__/nestjs-lambda-layer.stack.test.ts.snap
@@ -1,90 +1,90 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`MainStack should match snapshot test 1`] = `
+exports[`NestJsLambdaLayerStack should match snapshot test 1`] = `
 {
-  "Outputs": {
-    "NestJSLayerVersionArn": {
-      "Value": {
-        "Ref": "NestJsAppLayerF9ACDB87",
+  Outputs: {
+    NestJSLayerVersionArn: {
+      Value: {
+        Ref: NestJsAppLayerF9ACDB87,
       },
     },
   },
-  "Parameters": {
-    "BootstrapVersion": {
-      "Default": "/cdk-bootstrap/hnb659fds/version",
-      "Description": "Version of the CDK Bootstrap resources in this environment, automatically retrieved from SSM Parameter Store. [cdk:skip]",
-      "Type": "AWS::SSM::Parameter::Value<String>",
+  Parameters: {
+    BootstrapVersion: {
+      Default: /cdk-bootstrap/hnb659fds/version,
+      Description: Version of the CDK Bootstrap resources in this environment, automatically retrieved from SSM Parameter Store. [cdk:skip],
+      Type: AWS::SSM::Parameter::Value<String>,
     },
   },
-  "Resources": {
-    "NestJsAppLayerF9ACDB87": {
-      "DeletionPolicy": "Delete",
-      "Properties": {
-        "CompatibleArchitectures": [
-          "x86_64",
-          "arm64",
+  Resources: {
+    NestJsAppLayerF9ACDB87: {
+      DeletionPolicy: Delete,
+      Properties: {
+        CompatibleArchitectures: [
+          x86_64,
+          arm64,
         ],
-        "Content": {
-          "S3Bucket": {
-            "Fn::Sub": "cdk-hnb659fds-assets-\${AWS::AccountId}-\${AWS::Region}",
+        Content: {
+          S3Bucket: {
+            Fn::Sub: cdk-hnb659fds-assets-\${AWS::AccountId}-\${AWS::Region},
           },
-          "S3Key": "2640a05f1ab7f3b50acbdb9b4601513df930c8841534d0432bf112cb1b9f61e5.zip",
+          S3Key: UNIQUE_HASH.zip,
         },
-        "LayerName": {
-          "Fn::Join": [
-            "",
+        LayerName: {
+          Fn::Join: [
+            ,
             [
-              "arn:aws:lambda:",
+              arn:aws:lambda:,
               {
-                "Ref": "AWS::Region",
+                Ref: AWS::Region,
               },
-              ":",
+              :,
               {
-                "Ref": "AWS::AccountId",
+                Ref: AWS::AccountId,
               },
-              ":layer:NestJsAppLayer",
+              :layer:NestJsAppLayer,
             ],
           ],
         },
       },
-      "Type": "AWS::Lambda::LayerVersion",
-      "UpdateReplacePolicy": "Delete",
+      Type: AWS::Lambda::LayerVersion,
+      UpdateReplacePolicy: Delete,
     },
-    "lambdalayernestjslatestversionB188CF78": {
-      "Properties": {
-        "Description": "NestJS Lambda Layer Latest Version",
-        "Name": "lambda-layer-nestjs-latest-version",
-        "Type": "String",
-        "Value": {
-          "Ref": "NestJsAppLayerF9ACDB87",
+    lambdalayernestjslatestversionB188CF78: {
+      Properties: {
+        Description: NestJS Lambda Layer Latest Version,
+        Name: lambda-layer-nestjs-latest-version,
+        Type: String,
+        Value: {
+          Ref: NestJsAppLayerF9ACDB87,
         },
       },
-      "Type": "AWS::SSM::Parameter",
+      Type: AWS::SSM::Parameter,
     },
   },
-  "Rules": {
-    "CheckBootstrapVersion": {
-      "Assertions": [
+  Rules: {
+    CheckBootstrapVersion: {
+      Assertions: [
         {
-          "Assert": {
-            "Fn::Not": [
+          Assert: {
+            Fn::Not: [
               {
-                "Fn::Contains": [
+                Fn::Contains: [
                   [
-                    "1",
-                    "2",
-                    "3",
-                    "4",
-                    "5",
+                    1,
+                    2,
+                    3,
+                    4,
+                    5,
                   ],
                   {
-                    "Ref": "BootstrapVersion",
+                    Ref: BootstrapVersion,
                   },
                 ],
               },
             ],
           },
-          "AssertDescription": "CDK bootstrap stack version 6 required. Please run 'cdk bootstrap' with a recent version of the CDK CLI.",
+          AssertDescription: CDK bootstrap stack version 6 required. Please run 'cdk bootstrap' with a recent version of the CDK CLI.,
         },
       ],
     },

diff --git a/platform/lambda-layers/stacks/nestjs-lambda-layer.stack.test.ts b/platform/lambda-layers/stacks/nestjs-lambda-layer.stack.test.ts
@@ -2,11 +2,21 @@ import * as cdk from 'aws-cdk-lib';
 import { Template } from 'aws-cdk-lib/assertions';
 import { NestJsLambdaLayerStack } from './nestjs-lambda-layer.stack';
 
-describe('MainStack', () => {
+describe('NestJsLambdaLayerStack', () => {
   it('should match snapshot test', () => {
     const app = new cdk.App();
     const stack = new NestJsLambdaLayerStack(app, 'MyTestStack');
     const template = Template.fromStack(stack);
-    expect(template).toMatchSnapshot();
+
+    // TODO consider reworking to use DNS instead of incrementing and deploying each time
+    const customSnapshotSerializer = {
+      test: (val: any) => typeof val === 'string',
+      print: (val: any) => val
+        .replace(/deployment\d{8}T\d{9}Z[^:]+/, 'deployment_UNIQUE_HASH')
+        .replace(/[a-fA-F0-9]+\.zip/, 'UNIQUE_HASH.zip'),
+    };
+    expect.addSnapshotSerializer(customSnapshotSerializer);
+
+    expect(template.toJSON()).toMatchSnapshot();
   });
 });
diff --git a/platform/pipeline/package.json b/platform/pipeline/package.json
@@ -10,8 +10,8 @@
     "build": "tsc",
     "build:all": "rush build -t .",
     "watch": "tsc -w",
-    "test": "jest",
-    "test:cov": "jest --coverage",
+    "test": "jest --runInBand",
+    "test:cov": "jest --coverage --runInBand",
     "cdk": "cdk",
     "hotswap": "cdk deploy --hotswap",
     "lint": "",

diff --git a/services/admin-client/package.json b/services/admin-client/package.json
@@ -9,8 +9,8 @@
     "start": "next start",
     "lint": "next lint --fix",
     "lint:ci": "next lint",
-    "test": "jest --logHeapUsage",
-    "test:cov": "jest --coverage"
+    "test": "jest --runInBand",
+    "test:cov": "jest --coverage --runInBand"
   },
   "dependencies": {
     "@types/node": "20.8.2",

diff --git a/services/authentication-service/package.json b/services/authentication-service/package.json
@@ -8,8 +8,8 @@
     "build:all": "rush build -t .",
     "artifact": "create-artifact @cats-cradle/authentication-service",
     "watch": "tsc -w",
-    "test": "jest --logHeapUsage",
-    "test:cov": "jest --coverage",
+    "test": "jest --runInBand",
+    "test:cov": "jest --coverage --runInBand",
     "lint": "eslint --format visualstudio \"./{stacks,src}/**/*.ts\" --fix",
     "lint:ci": "eslint --format visualstudio \"./{stacks,src}/*.ts\" --fix-dry-run",
     "docs": "typedoc --entryPointStrategy expand ./src",

diff --git a/services/character-sheet/package.json b/services/character-sheet/package.json
@@ -8,8 +8,8 @@
     "build:all": "rush build -t .",
     "artifact": "create-artifact @cats-cradle/character-sheet",
     "watch": "tsc -w",
-    "test": "jest --logHeapUsage",
-    "test:cov": "jest --coverage",
+    "test": "jest --runInBand",
+    "test:cov": "jest --coverage --runInBand",
     "lint": "eslint --format visualstudio \"./{stacks,src}/**/*.ts\" --fix",
     "lint:ci": "eslint --format visualstudio \"./{stacks,src}/*.ts\" --fix-dry-run",
     "docs": "typedoc --entryPointStrategy expand ./src",

diff --git a/services/character-sheet/src/modules/character-sheet/character-sheet.e2e-spec.ts b/services/character-sheet/src/modules/character-sheet/character-sheet.e2e-spec.ts
@@ -59,6 +59,7 @@ describe('/character-sheets', () => {
       const response = await supertest(app.getHttpServer())
         .get(`/character-sheets/${v4()}`)
         .expect(404);
+
       expect(response.body).toMatchObject({
         message: 'Not Found',
         statusCode: 404,

diff --git a/services/email-service/package.json b/services/email-service/package.json
@@ -8,8 +8,8 @@
     "build:all": "rush build -t .",
     "artifact": "create-artifact @cats-cradle/email-service",
     "watch": "tsc -w",
-    "test": "jest --logHeapUsage",
-    "test:cov": "jest --coverage",
+    "test": "jest --runInBand",
+    "test:cov": "jest --coverage --runInBand",
     "lint": "eslint --format visualstudio \"./{stacks,src}/**/*.ts\"  --fix",
     "lint:ci": "eslint --format visualstudio \"./{stacks,src}/*.ts\"  --fix-dry-run",
     "docs": "typedoc --entryPointStrategy expand ./src",

diff --git a/services/html-to-pdf/package.json b/services/html-to-pdf/package.json
@@ -20,8 +20,8 @@
     "build": "tsc",
     "build:all": "rush build -t .",
     "watch": "tsc -w",
-    "test": "jest",
-    "test:cov": "jest --coverage",
+    "test": "jest --runInBand",
+    "test:cov": "jest --coverage --runInBand",
     "lint": "eslint --format visualstudio \"./src/**/*.ts\"  --fix",
     "lint:ci": "eslint --format visualstudio \"./src/**/*.ts\"  --fix-dry-run",
     "docs": "typedoc --entryPointStrategy expand ./src",

diff --git a/services/jukebox/package.json b/services/jukebox/package.json
@@ -8,8 +8,8 @@
     "build:all": "rush build -t .",
     "artifact": "create-artifact @cats-cradle/jukebox",
     "watch": "tsc -w",
-    "test": "jest --logHeapUsage",
-    "test:cov": "jest --coverage",
+    "test": "jest --runInBand",
+    "test:cov": "jest --coverage --runInBand",
     "lint": "eslint --format visualstudio \"./{stacks,src}/**/*.ts\"  --fix",
     "lint:ci": "eslint --format visualstudio \"./{stacks,src}/*.ts\"  --fix-dry-run",
     "docs": "typedoc --entryPointStrategy expand ./src",

diff --git a/services/luck-by-dice/package.json b/services/luck-by-dice/package.json
@@ -13,8 +13,8 @@
     "build": "tsc",
     "build:all": "rush build -t .",
     "watch": "tsc -w",
-    "test": "jest",
-    "test:cov": "jest --coverage",
+    "test": "jest --runInBand",
+    "test:cov": "jest --coverage --runInBand",
     "lint": "eslint --format visualstudio \"./src/**/*.ts\"  --fix",
     "lint:ci": "eslint --format visualstudio \"./src/**/*.ts\"  --fix-dry-run",
     "docs": "typedoc --entryPointStrategy expand ./src",

diff --git a/services/weather-control/package.json b/services/weather-control/package.json
@@ -7,8 +7,8 @@
     "build": "tsc",
     "build:all": "rush build -t .",
     "watch": "tsc -w",
-    "test": "jest --logHeapUsage",
-    "test:cov": "jest --coverage",
+    "test": "jest --runInBand",
+    "test:cov": "jest --coverage --runInBand",
     "lint": "eslint --format visualstudio \"./{stacks,src}/**/*.ts\"  --fix",
     "lint:ci": "eslint --format visualstudio \"./{stacks,src}/*.ts\"  --fix-dry-run",
     "docs": "typedoc --entryPointStrategy expand ./src",