fix: to pojo false check (#489)

Signed-off-by: hxtree <[email protected]>
hxtree · Nov 2, 2023 · 7cdf976 · 7cdf976
1 parent 8e2ee7a
commit 7cdf976
Show file tree

Hide file tree

Showing 17 changed files with 104 additions and 19 deletions.
diff --git a/libraries/faker-factory/CHANGELOG.json b/libraries/faker-factory/CHANGELOG.json
@@ -1,6 +1,18 @@
 {
   "name": "@cats-cradle/faker-factory",
   "entries": [
+    {
+      "version": "1.2.2",
+      "tag": "@cats-cradle/faker-factory_v1.2.2",
+      "date": "Thu, 02 Nov 2023 22:51:17 GMT",
+      "comments": {
+        "patch": [
+          {
+            "comment": "fix to pojo false check"
+          }
+        ]
+      }
+    },
     {
       "version": "1.2.1",
       "tag": "@cats-cradle/faker-factory_v1.2.1",

diff --git a/libraries/faker-factory/CHANGELOG.md b/libraries/faker-factory/CHANGELOG.md
@@ -1,6 +1,13 @@
 # Change Log - @cats-cradle/faker-factory
 
-This log was last generated on Thu, 02 Nov 2023 12:35:11 GMT and should not be manually modified.
+This log was last generated on Thu, 02 Nov 2023 22:51:17 GMT and should not be manually modified.
+
+## 1.2.2
+Thu, 02 Nov 2023 22:51:17 GMT
+
+### Patches
+
+- fix to pojo false check
 
 ## 1.2.1
 Thu, 02 Nov 2023 12:35:11 GMT

diff --git a/libraries/faker-factory/package.json b/libraries/faker-factory/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@cats-cradle/faker-factory",
-  "version": "1.2.1",
+  "version": "1.2.2",
   "main": "./dist/index.js",
   "repository": {
     "type": "git",

diff --git a/libraries/faker-factory/src/pojo.test.ts b/libraries/faker-factory/src/pojo.test.ts
@@ -22,14 +22,12 @@ describe('isPojo', () => {
     const sut = new TestClass();
     sut.a = 'Test';
 
-    expect(isPojo(sut)).toBeFalsy();
+    expect(isPojo(sut)).toBe(false);
   });
 
   it('should return true for pojo', () => {
-    const sut = new TestClass();
-    sut.a = 'Test';
-    const pojo = sut;
+    const sut = { a: 'Test' };
 
-    expect(isPojo(pojo)).toBeFalsy();
+    expect(isPojo(sut)).toBe(true);
   });
 });
diff --git a/libraries/faker-factory/src/pojo.ts b/libraries/faker-factory/src/pojo.ts
@@ -27,8 +27,5 @@ export function isPojo(obj: any): boolean {
     return false;
   }
 
-  const prototype = Object.getPrototypeOf(obj);
-
-  // If the prototype is null, it's a plain object
-  return prototype === null;
+  return Object.getPrototypeOf(obj) === Object.prototype;
 }
diff --git a/libraries/nestjs-modules/CHANGELOG.json b/libraries/nestjs-modules/CHANGELOG.json
@@ -1,6 +1,18 @@
 {
   "name": "@cats-cradle/nestjs-modules",
   "entries": [
+    {
+      "version": "0.2.8",
+      "tag": "@cats-cradle/nestjs-modules_v0.2.8",
+      "date": "Thu, 02 Nov 2023 22:51:17 GMT",
+      "comments": {
+        "dependency": [
+          {
+            "comment": "Updating dependency \"@cats-cradle/faker-factory\" to `1.2.2`"
+          }
+        ]
+      }
+    },
     {
       "version": "0.2.7",
       "tag": "@cats-cradle/nestjs-modules_v0.2.7",

diff --git a/libraries/nestjs-modules/CHANGELOG.md b/libraries/nestjs-modules/CHANGELOG.md
@@ -1,6 +1,11 @@
 # Change Log - @cats-cradle/nestjs-modules
 
-This log was last generated on Thu, 02 Nov 2023 12:35:11 GMT and should not be manually modified.
+This log was last generated on Thu, 02 Nov 2023 22:51:17 GMT and should not be manually modified.
+
+## 0.2.8
+Thu, 02 Nov 2023 22:51:17 GMT
+
+_Version update only_
 
 ## 0.2.7
 Thu, 02 Nov 2023 12:35:11 GMT

diff --git a/libraries/nestjs-modules/package.json b/libraries/nestjs-modules/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@cats-cradle/nestjs-modules",
-  "version": "0.2.7",
+  "version": "0.2.8",
   "main": "./dist/index.js",
   "repository": {
     "type": "git",

diff --git a/services/authentication-service/CHANGELOG.json b/services/authentication-service/CHANGELOG.json
@@ -1,6 +1,21 @@
 {
   "name": "@cats-cradle/authentication-service",
   "entries": [
+    {
+      "version": "1.0.9",
+      "tag": "@cats-cradle/authentication-service_v1.0.9",
+      "date": "Thu, 02 Nov 2023 22:51:17 GMT",
+      "comments": {
+        "dependency": [
+          {
+            "comment": "Updating dependency \"@cats-cradle/nestjs-modules\" to `0.2.8`"
+          },
+          {
+            "comment": "Updating dependency \"@cats-cradle/faker-factory\" to `1.2.2`"
+          }
+        ]
+      }
+    },
     {
       "version": "1.0.8",
       "tag": "@cats-cradle/authentication-service_v1.0.8",

diff --git a/services/authentication-service/CHANGELOG.md b/services/authentication-service/CHANGELOG.md
@@ -1,6 +1,11 @@
 # Change Log - @cats-cradle/authentication-service
 
-This log was last generated on Thu, 02 Nov 2023 12:35:11 GMT and should not be manually modified.
+This log was last generated on Thu, 02 Nov 2023 22:51:17 GMT and should not be manually modified.
+
+## 1.0.9
+Thu, 02 Nov 2023 22:51:17 GMT
+
+_Version update only_
 
 ## 1.0.8
 Thu, 02 Nov 2023 12:35:11 GMT

diff --git a/services/authentication-service/package.json b/services/authentication-service/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@cats-cradle/authentication-service",
   "module": "commonjs",
-  "version": "1.0.8",
+  "version": "1.0.9",
   "scripts": {
     "dev": "nest start --debug --watch",
     "build": "tsc",

diff --git a/services/email-service/CHANGELOG.json b/services/email-service/CHANGELOG.json
@@ -1,6 +1,18 @@
 {
   "name": "@cats-cradle/email-service",
   "entries": [
+    {
+      "version": "0.0.16",
+      "tag": "@cats-cradle/email-service_v0.0.16",
+      "date": "Thu, 02 Nov 2023 22:51:17 GMT",
+      "comments": {
+        "dependency": [
+          {
+            "comment": "Updating dependency \"@cats-cradle/faker-factory\" to `1.2.2`"
+          }
+        ]
+      }
+    },
     {
       "version": "0.0.15",
       "tag": "@cats-cradle/email-service_v0.0.15",

diff --git a/services/email-service/CHANGELOG.md b/services/email-service/CHANGELOG.md
@@ -1,6 +1,11 @@
 # Change Log - @cats-cradle/email-service
 
-This log was last generated on Thu, 02 Nov 2023 12:35:11 GMT and should not be manually modified.
+This log was last generated on Thu, 02 Nov 2023 22:51:17 GMT and should not be manually modified.
+
+## 0.0.16
+Thu, 02 Nov 2023 22:51:17 GMT
+
+_Version update only_
 
 ## 0.0.15
 Thu, 02 Nov 2023 12:35:11 GMT

diff --git a/services/email-service/package.json b/services/email-service/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@cats-cradle/email-service",
   "module": "commonjs",
-  "version": "0.0.15",
+  "version": "0.0.16",
   "scripts": {
     "dev": "nest start --debug --watch",
     "build": "tsc",

diff --git a/services/html-to-pdf/CHANGELOG.json b/services/html-to-pdf/CHANGELOG.json
@@ -1,6 +1,18 @@
 {
   "name": "@cats-cradle/html-to-pdf",
   "entries": [
+    {
+      "version": "1.0.10",
+      "tag": "@cats-cradle/html-to-pdf_v1.0.10",
+      "date": "Thu, 02 Nov 2023 22:51:17 GMT",
+      "comments": {
+        "dependency": [
+          {
+            "comment": "Updating dependency \"@cats-cradle/faker-factory\" to `1.2.2`"
+          }
+        ]
+      }
+    },
     {
       "version": "1.0.9",
       "tag": "@cats-cradle/html-to-pdf_v1.0.9",

diff --git a/services/html-to-pdf/CHANGELOG.md b/services/html-to-pdf/CHANGELOG.md
@@ -1,6 +1,11 @@
 # Change Log - @cats-cradle/html-to-pdf
 
-This log was last generated on Thu, 02 Nov 2023 12:35:11 GMT and should not be manually modified.
+This log was last generated on Thu, 02 Nov 2023 22:51:17 GMT and should not be manually modified.
+
+## 1.0.10
+Thu, 02 Nov 2023 22:51:17 GMT
+
+_Version update only_
 
 ## 1.0.9
 Thu, 02 Nov 2023 12:35:11 GMT

diff --git a/services/html-to-pdf/package.json b/services/html-to-pdf/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@cats-cradle/html-to-pdf",
   "module": "commonjs",
-  "version": "1.0.9",
+  "version": "1.0.10",
   "license": "MIT",
   "description": "Your Go-To Solution for PDF Generation from HTML.",
   "bugs": {