feat: echange pdf versioning to header

Signed-off-by: hxtree <[email protected]>
hxtree · Oct 14, 2023 · 60c7070 · 60c7070
1 parent 90a29e6
commit 60c7070
Show file tree

Hide file tree

Showing 8 changed files with 19 additions and 22 deletions.
diff --git a/common/config/rush/pnpm-lock.yaml b/common/config/rush/pnpm-lock.yaml
diff --git a/common/config/rush/repo-state.json b/common/config/rush/repo-state.json
@@ -1,5 +1,5 @@
 // DO NOT MODIFY THIS FILE MANUALLY BUT DO COMMIT IT. It is generated and used by Rush.
 {
-  "pnpmShrinkwrapHash": "ebb79fccecf409936dd8366f90b17a26b30e9b81",
+  "pnpmShrinkwrapHash": "6ac8d44a89914f6b48f857d90784482fdfe527f2",
   "preferredVersionsHash": "8ae0ba5bd02ec9c5763773a15e27aee08a6567f6"
 }
diff --git a/platform/bundlers/src/profiles/nestjs-bundler.ts b/platform/bundlers/src/profiles/nestjs-bundler.ts
@@ -17,6 +17,7 @@ export async function nestJsBundler(options: NestJsBundlerOptions) {
 
   try {
     const externalModules = [
+      // nestjs
       'express',
       'reflect-metadata',
       'rxjs',
@@ -32,6 +33,9 @@ export async function nestJsBundler(options: NestJsBundlerOptions) {
       'node-cache',
       'reflect-metadata',
       'rxjs',
+      // chromium
+      'puppeteer',
+      'chrome-aws-lambda',
     ];
 
     await build({

diff --git a/services/html-to-pdf/package.json b/services/html-to-pdf/package.json
@@ -48,9 +48,8 @@
     "@cats-cradle/validation-schemas": "workspace:*",
     "@nestjs/testing": "9.2.1",
     "@nestjs/axios": "~2.0.0",
-    "@sparticuz/chromium": "~117.0.0",
-    "puppeteer": "~21.3.8",
     "@cats-cradle/faker-factory": "workspace:*",
+    "puppeteer": "~21.3.8",
     "chrome-aws-lambda": "~10.1.0"
   },
   "devDependencies": {

diff --git a/services/html-to-pdf/src/index.ts b/services/html-to-pdf/src/index.ts
@@ -19,7 +19,8 @@ async function bootstrap() {
     );
 
     nestApp.enableVersioning({
-      type: VersioningType.URI,
+      type: VersioningType.HEADER,
+      header: 'Accept-Version',
       defaultVersion: '1',
     });
 

diff --git a/services/html-to-pdf/src/main.ts b/services/html-to-pdf/src/main.ts
@@ -9,7 +9,8 @@ async function bootstrap() {
   const app = await NestFactory.create(AppModule);
 
   app.enableVersioning({
-    type: VersioningType.URI,
+    type: VersioningType.HEADER,
+    header: 'Accept-Version',
     defaultVersion: '1',
   });
 

diff --git a/services/html-to-pdf/src/module/health/health.controller.ts b/services/html-to-pdf/src/module/health/health.controller.ts
@@ -1,7 +1,7 @@
-import { Controller, Get } from '@nestjs/common';
+import { Controller, Get, VERSION_NEUTRAL } from '@nestjs/common';
 import { HealthCheckService, HealthCheck } from '@nestjs/terminus';
 
-@Controller('health')
+@Controller({ path: 'health', version: ['1', VERSION_NEUTRAL] })
 export class HealthController {
   constructor(private health: HealthCheckService) {}
 

diff --git a/services/html-to-pdf/src/module/pdf/pdf.controller.ts b/services/html-to-pdf/src/module/pdf/pdf.controller.ts
@@ -1,12 +1,17 @@
 import {
-  Controller, Post, Body, Res, Get,
+  Controller,
+  Post,
+  Body,
+  Res,
+  Get,
+  VERSION_NEUTRAL,
 } from '@nestjs/common';
 import { Response } from 'express';
 import { PdfService } from './pdf.service';
 import { CreateHtmlToPdfDto } from './create-html-to-pdf.dto';
 import { CreateUrlToPdfDto } from './create-url-to-pdf.dto';
 
-@Controller({ path: 'pdf', version: ['1'] })
+@Controller({ path: 'pdf', version: ['1', VERSION_NEUTRAL] })
 export class PdfController {
   constructor(private readonly pdfService: PdfService) {}