Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shfmt #21

Merged
merged 1 commit into from
May 3, 2024
Merged

shfmt #21

merged 1 commit into from
May 3, 2024

Conversation

motiejus
Copy link
Collaborator

@motiejus motiejus commented May 3, 2024

Ran make lint. I am a fan of having a formatter for the source files. Let me know what you think, I obviously respect if you don't care as much (and we leave it as-is).

Also, as I am not a huge fan of third-party github actions, I opted to install shellcheck to the ubuntu image and run it from there.

Diff best previewed in git diff -w --word-diff.

@motiejus motiejus requested a review from hunleyd as a code owner May 3, 2024 11:34
@motiejus motiejus force-pushed the shfmt branch 4 times, most recently from 9907420 to 8df95cb Compare May 3, 2024 11:46
Ran `shfmt -w btrfs-auto-snapshot`. I am a fan of having a formatter
for the source files. Let me know what you think, I obviously respect if
you don't care as much (and we leave it as-is).

Also, as I am not a huge fan of third-party github actions, I opted to
install `shellcheck` to the ubuntu image and run it from there.

Diff best previewed in `git diff -w --word-diff`.
@hunleyd hunleyd merged commit e2d8246 into hunleyd:master May 3, 2024
1 check passed
@motiejus motiejus deleted the shfmt branch May 3, 2024 12:36
hunleyd added a commit that referenced this pull request May 5, 2024
* 'master' of github.com:hunleyd/btrfs-auto-snapshot:
  shfmt (#21)
  fix(btrfs-auto-snapshot): append a trailing / to all mountpoints (#18)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants