Add WP 5.5 Support #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance of some tests to make sure it hasn't changed? I am also wondering if the legacy code should be removed or kept with a check (either via the WP version or presence on filters) for people who are not sensible enough to leave these filters alone (I mean me ;). I'll pull down this branch and do some testing over the weekend and get back to you with a proper review. |
|
@peterwilsoncc I don't really have time to add tests right now. It's a difficult proposition for some elements of this plugin really but the server side stuff should be doable. I'm going to increase either the minor version or go for a 1.0.0 with this change either way to avoid compat issues, take your point regarding the version checks though 🤔 |
rmccue
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the new
wp_filter_content_tagsfunction with the equivalent for supporting Tachyon URLs.Fixes #49
See humanmade/altis-cms#239