Update to WordPress 5.5

[rmccue]

Integration issue for WordPress 5.5, which is planned for August.

Notable things we need to account for:

• Native lazy-loading - Needs integration in Media with Gaussholder
• CSS changes to buttons - Likely needs integration with CSS
• Editor updates in 5.5 - Some significant UI changes here I think
• WP_ENVIRONMENT_TYPE
• Image editing

Likely more to note too.

[rmccue]

Some raw Gutenberg screenshots from updating with no further changes:

Additionally, the mobile and tablet "preview" views are completely broken for me, showing a contentless preview about 20px tall, unsure if that's from our code or not (didn't get a screenshot).

Looks like our colour scheme will need updating, and we need to integrate with the new Gutenberg toolbar styling. The experiments and publication checklist features look fine and shouldn't need changes.

IMO, the Gutenberg toolbar styling looks terrible, and it's also very jarring as a user to see it change. It may be worth considering whether we can revert the visual changes altogether.

[rmccue]

Related, Gutenberg changelog for 5.5: WordPress/gutenberg#23669

[lachlanj]

It may be worth considering whether we can revert the visual changes altogether.

I'm not sure if this is a serious consideration or just a frustration with the new changes but I would hope that we don't try to revert this. WordPress has changed it's UI many times over the years for better or worse, but personally I think mostly for the better. It would be a shame to have to deviate from this.

[roborourke]

A REST API update is showing these warnings:

register_rest_route was called incorrectly. The REST API route definition for ... is missing the required permission_callback argument. For REST API routes that are intended to be public, use __return_true as the permission callback. Please see Debugging in WordPress for more information. (This message was added in version 5.5.0.)

This affects the following routes:

• workflows/v1/webhooks/(?P[\w\-\.]+)\/(?P[\w\-\.]+)
• workflows/v1/notifications/(?P[\d]+)/(?P[\d]+)
• workflows/v1/notifications/(?P[\d]+)
• elasticpress/v1/pointer_search
• elasticpress/v1/pointer_preview

[roborourke]

PR opened for Workflows, we may have to workaround the ElasticPress endpoint registry for now as I'm not sure when 3.5.0 which has the fix will ship.

[roborourke]

I looked into image editing, in short it sends rotation and crop data to the endpoint /wp/v2/media/:id/edit which handles the transformation and sends back a new attachment. While we could potentially hijack that endpoint and force it to return the same attachment with a modified URL containing the tachyon args there are 2 things standing in the way of that:

• Tachyon does not support rotating images via query string Support rotation tachyon#123
• Smart media editor does not support creating a one-off custom crop unrelated to an image size Support custom image crops not associated with an image size smart-media#92

As a result I don't believe this is something we can do super quickly for v5 because it's an infrastructure roll out and tricky media modal work.

[roborourke]

Marking this as done, the gaussholder one can come later is indirectly related.