Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shutil when looking for executables on the host system #1146

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Use shutil when looking for executables on the host system #1146

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f053502
Use shutil when looking for executables on the host system
mkrasnitski Oct 28, 2024
a00d9f1
Apply review suggestion
mkrasnitski Oct 28, 2024
13ff22c
Apply review suggestion
mkrasnitski Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions gef.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1936,13 +1936,11 @@ def gef_pybytes(x: str) -> bytes:
@lru_cache()
def which(program: str) -> pathlib.Path:
"""Locate a command on the filesystem."""
for path in os.environ["PATH"].split(os.pathsep):
dirname = pathlib.Path(path)
fpath = dirname / program
if os.access(fpath, os.X_OK):
return fpath

raise FileNotFoundError(f"Missing file `{program}`")
path = shutil.which(program)
if path:
return pathlib.Path(path)
else:
mkrasnitski marked this conversation as resolved.
Show resolved Hide resolved
raise FileNotFoundError(f"Missing file `{program}`")


def style_byte(b: int, color: bool = True) -> str:
Expand Down
Loading