Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup session managers to encapsulate & defer better #1066

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Conversation

Grazfather
Copy link
Collaborator

gef.session points to a session manager and keeps state, but was often referencing gef.session instead of self. Also, some checks for remote sessions were unnecessary: Since the session has a remote attribute, callers on the session can count on the session manager to provide the correct data/function

Copy link

🤖 Coverage update for 8822e39 🟢

Old New
Commit c17a0d2 8822e39
Score 71.5816% 71.5844% (0.0028)

Copy link

🤖 Coverage update for 8822e39 🔴

Old New
Commit c17a0d2 8822e39
Score 71.5816% 71.5623% (-0.0193)

@hugsy hugsy merged commit 4b47c6d into main Jan 31, 2024
7 checks passed
@hugsy hugsy added this to the 2024.05 milestone Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants