Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix python version parsing #1058

Merged
merged 1 commit into from
Jan 27, 2024
Merged

fix python version parsing #1058

merged 1 commit into from
Jan 27, 2024

Conversation

samas69420
Copy link
Contributor

Description

get python version using the stem function from pathlib instead of list slicing

with list slicing assertion fails while using pyenv bacuse the path is wrong

Checklist

  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • If my change adds new code, adequate tests have been added.
  • I have read and agree to the CONTRIBUTING document.

the "is_dir()" assertion is failing with pyenv, using the stem function to parse the version of python fix the issue
Copy link

🤖 Coverage update for a96d4cb 🟢

Old New
Commit 570cc03 a96d4cb
Score 71.5623% 71.5623% (0)

Copy link
Collaborator

@Grazfather Grazfather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

til Path.stem

@hugsy hugsy merged commit ece5728 into hugsy:main Jan 27, 2024
7 checks passed
@samas69420 samas69420 mentioned this pull request Jan 28, 2024
@hugsy hugsy added this to the 2024.05 milestone Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] pyenv site_packages_dir assertion fails when setting multiple python versions in pyenv
3 participants