Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse_arguments: Fix bool type #1056

Merged
merged 1 commit into from
Jan 26, 2024
Merged

parse_arguments: Fix bool type #1056

merged 1 commit into from
Jan 26, 2024

Conversation

Grazfather
Copy link
Collaborator

@Grazfather Grazfather commented Jan 24, 2024

The parse args set the default argument value behaviour for bools inconsistenly with the other types: A function had to say 'False' if it wanted the default to be 'True'. This fixes that.

Copy link

🤖 Coverage update for b513ae8 🟢

Old New
Commit 219d46f b513ae8
Score 71.7764% 71.7959% (0.0195)

Copy link

🤖 Coverage update for b513ae8 🟢

Old New
Commit 219d46f b513ae8
Score 71.7764% 71.7791% (0.0027)

The parse args set the arg behaviour inconsistenly with the other types:
A function had to say 'False' if it wanted the default to be 'True'.
This fixes that.
Copy link

🤖 Coverage update for a5620e3 🟢

Old New
Commit 219d46f a5620e3
Score 71.7764% 71.7764% (0)

Copy link

🤖 Coverage update for a5620e3 🟢

Old New
Commit 219d46f a5620e3
Score 71.7764% 71.7791% (0.0027)

@Grazfather Grazfather changed the title parse_args: Fix bool type parse_arguments: Fix bool type Jan 24, 2024
Copy link

🤖 Coverage update for 98d59b6 🟢

Old New
Commit 219d46f 98d59b6
Score 71.7764% 71.7959% (0.0195)

Copy link

🤖 Coverage update for 98d59b6 🟢

Old New
Commit 219d46f 98d59b6
Score 71.7764% 71.7791% (0.0027)

@hugsy
Copy link
Owner

hugsy commented Jan 26, 2024

I swear there was a valid reason for default to True but I cannot remember it. Let's go ahead with it, it's not a change that'll break core functionalities anyway.

@Grazfather Grazfather merged commit 13a9339 into main Jan 26, 2024
6 checks passed
@Grazfather Grazfather deleted the fix_parse_arguments branch January 26, 2024 20:23
hugsy added a commit to hugsy/gef-extras that referenced this pull request Jan 28, 2024
@Grazfather Grazfather mentioned this pull request Jan 30, 2024
4 tasks
@hugsy hugsy added this to the 2024.05 milestone Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants