-
-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Killing the last inconsistencies through type hints #1052
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugsy
changed the title
Killing more inconsistencies through type hints
Killing the last inconsistencies through type hints
Jan 25, 2024
Grazfather
approved these changes
Jan 25, 2024
Co-authored-by: Grazfather <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is purely esthetic but fixes a few extra inconsistencies thanks to type hints, using
pylint
andpylance
.Both pass now reporting no error, warning or info!
Among other fixes:
f-string
-ify moreassert
) expected type to variable when appropriategdb.events.*
staticmethod
have been made non static because we can usegef.gdb.commands["XXX"]
insteadWith this PR :
pylint
on gef and tests/*.py shows a 10/10 scorepylance
shows no errorChecklist