Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support user-supplied <head> html #244

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

jannes
Copy link
Contributor

@jannes jannes commented Oct 10, 2024

If theme user creates a "custom-head.html" partial, it will be included at the end of the section.

Related discussion: #152

PR Checklist

  • I have verified that the code works as described/as intended.
  • This change adds a social icon which has a permissive license to use it.
  • This change does not include any external library/resources.
  • This change does not include any unrelated scripts (e.g. bash and python scripts).
  • I have enabled maintainer edits for this PR.

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for hugo-blog-awesome ready!

Name Link
🔨 Latest commit b48e265
🔍 Latest deploy log https://app.netlify.com/sites/hugo-blog-awesome/deploys/670b390fc025450008fd7453
😎 Deploy Preview https://deploy-preview-244--hugo-blog-awesome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hugo-sid
Copy link
Owner

Thanks for the feature @jannes. Could you please add the relevant documentation on README?

@jannes
Copy link
Contributor Author

jannes commented Oct 12, 2024

Sure, I will update the PR when I am back at my computer :)

@jannes jannes force-pushed the custom-head-extension branch from 4b14884 to a2b53d5 Compare October 13, 2024 03:03
If theme user creates a "custom-head.html" partial, it will be included
at the end of the <head> section.
@jannes jannes force-pushed the custom-head-extension branch from a2b53d5 to b48e265 Compare October 13, 2024 03:05
Copy link

sonarcloud bot commented Oct 13, 2024

@jannes
Copy link
Contributor Author

jannes commented Oct 13, 2024

Does that look good to you? Not sure whether an example is necessary?

Copy link
Owner

@hugo-sid hugo-sid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jannes for this new feature.

Does that look good to you? Not sure whether an example is necessary?

LGTM.

@hugo-sid hugo-sid merged commit 6b0e47a into hugo-sid:main Oct 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants