-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added pt-br translation #233
Conversation
✅ Deploy Preview for hugo-blog-awesome ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@devnull-hub-lab thanks for adding pt-br i18n file.
Kindly note that you have completed one of the three steps required to add a new language. For further details, please refer to the contribution guidelines here:
https://github.com/hugo-sid/hugo-blog-awesome/blob/main/CONTRIBUTING.md#adding-a-new-language
Hi @hugo-sid Thanks for accepting. Yes, I think (just my opinion) that if you include every translated language in hugo.toml, it could inflate hugo.toml unnecessarily, as most people only use one or two translations at most. My suggestion (if you accept it) would be to keep only 3 translations in hugo.toml and just add a comment with information that there are translations in other languages too, without necessarily replicating the codes in all translated languages. In any case, if you prefer to keep all translated languages in hugo.toml, replicating the menu code for them and including them in ExampleSite, let me know and I'll make the PR for these changes. |
Hi @devnull-hub-lab,
I prefer this way. Kindly proceed & make the necessary changes to this PR. Please note that, you have to take care of the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, sure!
Its done.
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @devnull-hub-lab for adding pt-br translation.
Added pt-br translation (i18n Internationalization)