Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added pt-br translation #233

Merged
merged 3 commits into from
Sep 21, 2024
Merged

added pt-br translation #233

merged 3 commits into from
Sep 21, 2024

Conversation

devnull-hub-lab
Copy link
Contributor

Added pt-br translation (i18n Internationalization)

Copy link

netlify bot commented Sep 4, 2024

Deploy Preview for hugo-blog-awesome ready!

Name Link
🔨 Latest commit 878a729
🔍 Latest deploy log https://app.netlify.com/sites/hugo-blog-awesome/deploys/66e4d4ab8bb45a00088a7692
😎 Deploy Preview https://deploy-preview-233--hugo-blog-awesome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@hugo-sid hugo-sid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devnull-hub-lab thanks for adding pt-br i18n file.

Kindly note that you have completed one of the three steps required to add a new language. For further details, please refer to the contribution guidelines here:
https://github.com/hugo-sid/hugo-blog-awesome/blob/main/CONTRIBUTING.md#adding-a-new-language

@devnull-hub-lab
Copy link
Contributor Author

devnull-hub-lab commented Sep 7, 2024

Hi @hugo-sid

Thanks for accepting.

Yes, I think (just my opinion) that if you include every translated language in hugo.toml, it could inflate hugo.toml unnecessarily, as most people only use one or two translations at most. My suggestion (if you accept it) would be to keep only 3 translations in hugo.toml and just add a comment with information that there are translations in other languages too, without necessarily replicating the codes in all translated languages.

In any case, if you prefer to keep all translated languages ​​in hugo.toml, replicating the menu code for them and including them in ExampleSite, let me know and I'll make the PR for these changes.

@hugo-sid
Copy link
Owner

hugo-sid commented Sep 9, 2024

Hi @devnull-hub-lab,

In any case, if you prefer to keep all translated languages ​​in hugo.toml, replicating the menu code for them and including them in ExampleSite, let me know and I'll make the PR for these changes.

I prefer this way. Kindly proceed & make the necessary changes to this PR.

Please note that, you have to take care of the following:

  • Add language specific configuration and parameters in exampleSite/hugo.toml
  • Translate specific terms by creating a new language-specific file in the i18n directory
  • Add translated content in exampleSite/content directory

@github-actions github-actions bot added size/xl and removed size/xs labels Sep 13, 2024
Copy link
Contributor Author

@devnull-hub-lab devnull-hub-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, sure!
Its done.

Copy link

sonarcloud bot commented Sep 14, 2024

Copy link
Owner

@hugo-sid hugo-sid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @devnull-hub-lab for adding pt-br translation.

@hugo-sid hugo-sid merged commit 06317c8 into hugo-sid:main Sep 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants