Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stackshare.io svg icon #179

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

jdmartinho
Copy link
Contributor

What problem does this PR solve?

Added the stackshare.io SVG icon

Is this PR adding a new feature?

Nope

Is this PR related to any issue or discussion?

PR Checklist

  • I have verified that the code works as described/as intended.
  • This change adds a social icon which has a permissive license to use it.
  • This change does not include any external library/resources.
  • This change does not include any unrelated scripts (e.g. bash and python scripts).
  • I have enabled maintainer edits for this PR.

Copy link

netlify bot commented Mar 21, 2024

👷 Deploy Preview for hugo-blog-awesome processing.

Name Link
🔨 Latest commit 6f61322
🔍 Latest deploy log https://app.netlify.com/sites/hugo-blog-awesome/deploys/65fc1d638be58d0007fce23d

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

netlify bot commented Mar 21, 2024

Deploy Preview for hugo-blog-awesome ready!

Name Link
🔨 Latest commit 6f61322
🔍 Latest deploy log https://app.netlify.com/sites/hugo-blog-awesome/deploys/65fc1d638be58d0007fce23d
😎 Deploy Preview https://deploy-preview-179--hugo-blog-awesome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@hugo-sid hugo-sid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jdmartinho thanks for adding stackshare.io icon.

I enjoyed reading this: https://jdmartinho.com/posts/compound-interest-in-your-career-how-use-the-power-of-the-environment-to-accelerate-your-professional-growth.
I learned a lot from it.

I also happened to see https://jdmartinho.github.io/ which uses this theme. I have a minor suggestion regarding it: you may want to change the favicons. Currently the theme's favicons are appearing on this website.

@hugo-sid hugo-sid merged commit 7069c5a into hugo-sid:main Mar 21, 2024
7 checks passed
@hugo-sid
Copy link
Owner

@jdmartinho you may update the git submodule (at https://github.com/jdmartinho/jdmartinho.github.io) to use the stackshare.io icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants