Add useToJSON option #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just noticed that this tackle the same use case as #61 . However, I think that this is much simpler. |
|
Just wanted to get this on someones radar |
|
@knownasilya @juanjoDiaz I've decided to fork and republish as I get the feeling that this project is abandoned. I've re-released as flatley. Feel free to open PR there if I've missed anything from yours. https://www.npmjs.com/package/flatley |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request add a new option to the library to force using the
toJSONmethod of objects when it exits and it's the element is not a primitive (so it doesn't affect Dates). This allow to correctly flatten object as they would be if it was stringified to a JSON object usingJSON.stringify. (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON/stringify)This PR fixes an issue in a downstream library that I'm having at the moment, related to mongodb's ObjectIDs being incorrectly flattened (zemirco/json2csv#175). However, I don't think that it's an isolated case. I believe it's a case common enough to have this extra option.
The PR contains unit test coverage for the change. Please let me know if everything is ok or if I need to do anything else.