Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing dataloader prefetching to work with iterable datasets. #34925

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Lucaweihs
Copy link

What does this PR do?

This PR fixes #34867 which noted that dataloader prefetching was not occurring for iterable datasets. This PR also refactors the dataloader creation code in the trainer so that the train/eval/test dataloaders all use the same underlying function rather than repeating the same logic in multiple places. I added two tests to confirm that the prefetching works with iterable datasets as expected.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline, Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@muellerzr @SunMarc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data prefetching does not occur for iterable datasets
1 participant