Allowing dataloader prefetching to work with iterable datasets. #34925
+167
−74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes #34867 which noted that dataloader prefetching was not occurring for iterable datasets. This PR also refactors the dataloader creation code in the trainer so that the train/eval/test dataloaders all use the same underlying function rather than repeating the same logic in multiple places. I added two tests to confirm that the prefetching works with iterable datasets as expected.
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@muellerzr @SunMarc