New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: incorrect background color for LanguageSelector in dark mode #1092

Open

nekomeowww wants to merge 1 commit into huggingface:main from nekomeowww:dev/webgpu-whisper-dark-view-issue

nekomeowww commented Dec 10, 2024

Summary

The default background color of <select>will cause the <select> to be bad to see the texts in it which violates the best practice of minimum color contrast of texts in accessibilities guidelines.

Changes

Added bg-transparent to omit out the background for <select>.
Auto format and added a space line for better EOF handling.

Side by side screenshots of changes

Color Mode	Before	After
Day (white)
Night (dark)


          style: incorrect background color for LanguageSelector in dark mode

8216ee5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet