Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test training of examples with torchrun call #319

Merged
merged 2 commits into from
Jun 7, 2023

Conversation

ljaljushkin
Copy link
Contributor

What does this PR do?

Updated the example tests to be launched in the way it's recommended in the readme: #315
Previous way without setting CUDA_VISIBLE_DEVICES can lead to training in Data Parallel mode, which is slower and can even fail with error: openvinotoolkit/nncf#1582

Copy link
Collaborator

@helena-intel helena-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @ljaljushkin !

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 22, 2023

The documentation is not available anymore as the PR was closed or merged.

@helena-intel
Copy link
Collaborator

@ljaljushkin could you run make style in the root of the repository, to fix the code quality check? pip install optimum-intel[quality] for the requirements for that.

@ljaljushkin
Copy link
Contributor Author

@ljaljushkin could you run make style in the root of the repository, to fix the code quality check? pip install optimum-intel[quality] for the requirements for that.

thank you, reformatted!

Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants