Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #314

Merged
merged 2 commits into from
Dec 21, 2024
Merged

fix #314

merged 2 commits into from
Dec 21, 2024

Conversation

kylematoba
Copy link
Contributor

file path arg is in class constructor.

@guipenedo
Copy link
Collaborator

Thanks, can you run the style fixer? https://github.com/huggingface/datatrove?tab=readme-ov-file#contributing

@kylematoba
Copy link
Contributor Author

There seems to be some problem with the instructions at that link:


The conflict is caused by:
    datatrove 0.4.0 depends on numpy>=2.0.0
    datatrove[dev] 0.4.0 depends on numpy>=2.0.0
    datatrove[all] 0.4.0 depends on numpy>=2.0.0
    datatrove[quality] 0.4.0 depends on numpy>=2.0.0
    datatrove[testing] 0.4.0 depends on numpy>=2.0.0
    datatrove[cli] 0.4.0 depends on numpy>=2.0.0
    datatrove[io] 0.4.0 depends on numpy>=2.0.0
    datatrove[multilingual] 0.4.0 depends on numpy>=2.0.0
    spacy[ja] 3.8.2 depends on numpy>=1.19.0; python_version >= "3.9"
    datatrove[processing] 0.4.0 depends on numpy>=2.0.0
    datatrove[s3] 0.4.0 depends on numpy>=2.0.0
    datasets 3.1.0 depends on numpy>=1.17
    spacy 3.8.2 depends on numpy>=1.19.0; python_version >= "3.9"
    tensorflow 2.16.2 depends on numpy<2.0.0 and >=1.26.0; python_version >= "3.12"
    datatrove 0.4.0 depends on numpy>=2.0.0
    datatrove[dev] 0.4.0 depends on numpy>=2.0.0
    datatrove[all] 0.4.0 depends on numpy>=2.0.0
    datatrove[quality] 0.4.0 depends on numpy>=2.0.0
    datatrove[testing] 0.4.0 depends on numpy>=2.0.0
    datatrove[cli] 0.4.0 depends on numpy>=2.0.0
    datatrove[io] 0.4.0 depends on numpy>=2.0.0
    datatrove[multilingual] 0.4.0 depends on numpy>=2.0.0
    spacy[ja] 3.8.2 depends on numpy>=1.19.0; python_version >= "3.9"
    datatrove[processing] 0.4.0 depends on numpy>=2.0.0
    datatrove[s3] 0.4.0 depends on numpy>=2.0.0
    datasets 3.1.0 depends on numpy>=1.17
    spacy 3.8.2 depends on numpy>=1.19.0; python_version >= "3.9"
    tensorflow 2.16.1 depends on numpy<2.0.0 and >=1.26.0; python_version >= "3.12"

But I ruff formatted it.

@guipenedo guipenedo merged commit 61d4f86 into huggingface:main Dec 21, 2024
4 checks passed
@guipenedo
Copy link
Collaborator

LGTM, ty :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants