Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix languages listify bug #294

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Fix languages listify bug #294

merged 1 commit into from
Oct 17, 2024

Conversation

BramVanroy
Copy link
Contributor

If the passed language is a string, it should be turned into a list like this [languages] rather than list(languages). The latter will turn a string into a list of its individual characters.

>>> list("en")
['e', 'n']
>>> ["en"]
['en']

@hynky1999
Copy link
Contributor

Good catch 👍

@hynky1999
Copy link
Contributor

Merging this as tests are failing due to different reason than this PR

@hynky1999 hynky1999 merged commit e648dfe into huggingface:main Oct 17, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants