-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add open-source text extraction libraries #293
Open
garrethlee
wants to merge
32
commits into
main
Choose a base branch
from
feat/text-extraction
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… initialization - Added a default `clean_html` method to the `BaseExtractor` class, providing a warning for extractors that do not implement their own. - Implemented specific `clean_html` methods in `Inscriptis`, `Justext`, `ReadabiliPy`, `Readability`, and `Trafilatura` extractors to handle HTML cleaning. - Updated the `Inscriptis` extractor to accept a preprocessor during initialization. - Modified the `extract` methods in `ReadabiliPy` and `Readability` to utilize the new `clean_html` method. - Adjusted the `Justext` extractor to remove the default English language parameter from `get_stoplist`. - Updated tests to reflect changes in extractor initialization and functionality.
… initialization - Added a default `clean_html` method to the `BaseExtractor` class, providing a warning for extractors that do not implement their own. - Implemented specific `clean_html` methods in `Inscriptis`, `Justext`, `ReadabiliPy`, `Readability`, and `Trafilatura` extractors to handle HTML cleaning. - Updated the `Inscriptis` extractor to accept a preprocessor during initialization. - Modified the `extract` methods in `ReadabiliPy` and `Readability` to utilize the new `clean_html` method. - Adjusted the `Justext` extractor to remove the default English language parameter from `get_stoplist`. - Updated tests to reflect changes in extractor initialization and functionality.
…n' into feat/text-extraction
garrethlee
changed the title
Add several open-source text extraction libraries
Add open-source text extraction libraries
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored extraction logic to separate HTML cleaning and text extraction into distinct steps. This allows chaining the cleaning step from one library with the extraction step from another, enhancing flexibility and interoperability.
Context
extract
function works independently, whileclean_html
is reserved for interoperability scenarios like inscriptis.Thus, we break down the extraction functionality into the two phases referenced above, in the form of a
clean_html
andextract
method in eachExtractor
.Changes
clean_html
as a standalone method in extractors