-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add use_all_gather for option #3164
base: main
Are you sure you want to change the base?
Conversation
Also have additional question for LLM inference evaluation process. Does LLM evaluation process requires to have |
Thanks! Tests should be in The |
@muellerzr Hi I haved added test. However, to be more strict test I think we can add additional checking when the process is not in the |
@muellerzr Gentle Ping! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since using all_gather
uses more memory by default, let's set a default to False
please (even though we said the opposite initially I think)
re; test:I think it's fine how it is right now |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
What does this PR do?
Fixes #3147
@muellerzr
I think testing might need but not sure where to add this corresponding test
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.