Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff comment workflow #92

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Diff comment workflow #92

merged 3 commits into from
Jul 24, 2024

Conversation

zkamvar
Copy link
Member

@zkamvar zkamvar commented Jul 23, 2024

This workflow will run whenever one of use (the repo owners) adds the /diff comment in a pull request. It will generate a highlighted diff of the schema as a GitHub comment.

This uses two external actions

I've updated the README to highlight the automatic generation of diffs, while leaving @annakrystalli instructions for manually creating the diffs as a backup

@zkamvar zkamvar requested a review from annakrystalli July 23, 2024 15:03
@zkamvar zkamvar marked this pull request as ready for review July 23, 2024 15:04
Copy link
Member

@annakrystalli annakrystalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks @zkamvar

I'm going to wait till the review (which has already begun in #88) is complete and will merge this in after before merging into main.

@annakrystalli annakrystalli merged commit 9734436 into v3.0.1-branch Jul 24, 2024
1 check passed
@annakrystalli annakrystalli deleted the diff-comment-workflow branch July 24, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants