Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo on required cloud field #69

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Fix typo on required cloud field #69

merged 1 commit into from
Mar 12, 2024

Conversation

bsweger
Copy link
Contributor

@bsweger bsweger commented Mar 12, 2024

Didn't catch this one because I tested the validations on the original version of the v2.0.1 PR and didn't re-test when adding additional properties based on feedback.

I think the fix here is to get this reviewed and merged, and then update the commit referenced by the v2.0.1 tag, but please let me know if that's not correct!

Didn't catch this one because I tested the validations on the
original version of the v2.0.1 PR and didn't re-test when adding
additional properties based on feedback.
Copy link
Contributor

@elray1 elray1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elray1 elray1 merged commit 5585912 into main Mar 12, 2024
3 checks passed
@elray1 elray1 deleted the bsweger/fix-cloud-typo branch March 12, 2024 18:31
@bsweger bsweger added this to the hubverse cloud sync milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants