Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict target_keys object to contain only a single key value pair. #118

Open
wants to merge 1 commit into
base: br-v4.0.1
Choose a base branch
from

Conversation

annakrystalli
Copy link
Member

@annakrystalli annakrystalli commented Dec 18, 2024

This PR resolves #117 by restricting target_keys objects to contain only a single key value pair.

Successful validation is demonstrated in hubAdmin PR hubverse-org/hubAdmin#90 and more specifically in these tests using this and this test file.

Question

Should we also remove target_variable and target_outcome from the schema? These were originally added as standard task ids (and are documented as such in hubDocs) for the following reason:

target_variable/target_outcome: task IDs making up unique identifiers of a two-part target. These tasks can be used in hubs that want to divide the definition of a target across two variables. Both task IDs will be specified as target keys in the target_metadata array.

The answer also therefore has implications on hubverse-org/hubDocs#226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only allow a single target_keys key value pair
1 participant