🐛 Separate v4 req vals checks by output type. Resolves #177 #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkamvar
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Thank you for the quick turnaround on this! The solution (checking each output type individually) makes sense and the test is clear. And I like that you included the issue number in the tests.
At some point I'd like to pick your brain about how these checks work and why this approach can only work for v4, but that's for later.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug reported in #177 . It appeared that the new logic behind optional output types having all required values was not being handled properly and as a result evaluations of different output types were leaking into checks of other output types returning non-sensical false positives.
Given the fact that in v4 we have a much easier way of determining whether an output type should be examined (all
is_required+ any optional output type submitted, an optimisation I was planning to make to reduce memory pressure and speed up required value validation was to chunk the evaluation by output type, sth that was not possible with v3. Turns out this optimisation also keeps things clean and fixes the bug reported in #177! Double win!