[chore] tidy testing environment

[zkamvar]

I noticed that I was getting errors during testing because of a couple of factors unrelated to the actual validity of the code:

1. I did not have testthis installed
2. Folders created inside of tempdir() are not cleaned up leading to errors when re-running the tests because the folders are not empty.

I fixed the first with skip_if_not_installed() and the second by using withr::local_tempdir()

[github-actions]

🚀 Deployed on https://66bb6679d982563fe557f343--hubvalidations-pr-previews.netlify.app

[annakrystalli]

Thanks for the PR @zkamvar !

Fix for 2. I'm very happy to accept. Much cleaner indeed and makes working interactively with tests much smoother.

Regarding testthis, it is listed in Suggests and I would expect anyone contributing code to install the full list of dependencies and be able to run the full suite of tests, build all docs etc before making a PR. So I would prefer to remove those skips

[zkamvar]

Regarding testthis, it is listed in Suggests and I would expect anyone contributing code to install the full list of dependencies and be able to run the full suite of tests, build all docs etc before making a PR. So I would prefer to remove those skips

That's fair. I've removed them. Feel free to squash-merge this since it amounts to exactly one change effectively.

[annakrystalli]

Feel free to squash-merge this since it amounts to exactly one change effectively.

Honestly I'm not 100% percent how to do that. Is it git reset --soft HEAD~3?

[annakrystalli]

All good!

[zkamvar]

Feel free to squash-merge this since it amounts to exactly one change effectively.

Honestly I'm not 100% percent how to do that. Is it git reset --soft HEAD~3?

[annakrystalli]

Feel free to squash-merge this since it amounts to exactly one change effectively.

Honestly I'm not 100% percent how to do that. Is it git reset --soft HEAD~3?

Awesome! Thanks!