Skip to content

Commit

Permalink
Clarify ref_date_from docs
Browse files Browse the repository at this point in the history
  • Loading branch information
annakrystalli committed Dec 19, 2023
1 parent dec916d commit b134ad2
Show file tree
Hide file tree
Showing 7 changed files with 44 additions and 26 deletions.
9 changes: 6 additions & 3 deletions R/check_submission_time.R
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
#' Checks submission is within the valid submission window for a given round.
#'
#' @param ref_date_from whether to get the round ID around which relative submission
#' windows will be determined from the file's `file_path` or the `file` contents
#' themselves. `file` requires that the file can be read.
#' @param ref_date_from whether to get the reference date around
#' which relative submission windows will be determined from the file's
#' `file_path` round ID or the `file` contents themselves.
#' `file` requires that the file can be read.
#' Only applicable when a round is configured to determine the submission
#' windows relative to the value in a date column in model output files.
#' Not applicable when explicit submission window start and end dates are
#' provided in the hub's config.
#'
#' @inherit check_tbl_col_types params return
#'
Expand Down
4 changes: 2 additions & 2 deletions R/validate_pr.R
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@
#'
#' Note that to establish **relative** submission windows when performing
#' modification/deletion checks and `allow_submit_window_mods`
#' is `TRUE`, the _relative to_ date is considered as the `round_id` extracted from
#' is `TRUE`, the reference date is taken as the `round_id` extracted from
#' the file path (i.e. `submit_window_ref_date_from` is always set to `"file_path"`).
#' This is because we cannot extract dates from columns of deleted
#' files. If hub _relative to_ dates do not match the round IDs in file paths,
#' files. If hub submission window reference dates do not match round IDs in file paths,
#' currently `allow_submit_window_mods` will not work correctly and is best set
#' to `FALSE`. This only relates to hubs/rounds where submission windows are
#' determined relative to a reference date and not when explicit submission
Expand Down
9 changes: 6 additions & 3 deletions R/validate_submission.R
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,14 @@
#' @param skip_submit_window_check Logical. Whether to skip the submission window check.
#' @param skip_check_config Logical. Whether to skip the hub config validation check.
#' check.
#' @param submit_window_ref_date_from whether to get the round ID around which relative submission
#' windows will be determined from the file's `file_path` or the `file` contents
#' themselves. `file` requires that the file can be read.
#' @param submit_window_ref_date_from whether to get the reference date around
#' which relative submission windows will be determined from the file's
#' `file_path` round ID or the `file` contents themselves.
#' `file` requires that the file can be read.
#' Only applicable when a round is configured to determine the submission
#' windows relative to the value in a date column in model output files.
#' Not applicable when explicit submission window start and end dates are
#' provided in the hub's config.
#' @export
#'
#' @examples
Expand Down
11 changes: 7 additions & 4 deletions man/check_submission_time.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 9 additions & 6 deletions man/validate_pr.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 7 additions & 4 deletions man/validate_submission.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 7 additions & 4 deletions man/validate_submission_time.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit b134ad2

Please sign in to comment.